Commit e610e856 authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Chandan Babu R
Browse files

xfs: fix scrub stats file permissions 



When the kernel is in lockdown mode, debugfs will only show files that
are world-readable and cannot be written, mmaped, or used with ioctl.
That more or less describes the scrub stats file, except that the
permissions are wrong -- they should be 0444, not 0644.  You can't write
the stats file, so the 0200 makes no sense.

Meanwhile, the clear_stats file is only writable, but it got mode 0400
instead of 0200, which would make more sense.

Fix both files so that they make sense.

Fixes: d7a74cad ("xfs: track usage statistics of online fsck")
Signed-off-by: default avatar"Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarChandan Babu R <chandanbabu@kernel.org>
parent 1e5efd72

fs/xfs/scrub/stats.c

+2 −2
Original line number Diff line number Diff line
@@ -331,9 +331,9 @@ xchk_stats_register( 
	if (!cs->cs_debugfs)

		return;



	debugfs_create_file("stats", 0644, cs->cs_debugfs, cs,

	debugfs_create_file("stats", 0444, cs->cs_debugfs, cs,

			&scrub_stats_fops);

	debugfs_create_file("clear_stats", 0400, cs->cs_debugfs, cs,

	debugfs_create_file("clear_stats", 0200, cs->cs_debugfs, cs,

			&clear_scrub_stats_fops);

}