Commit e63f5918 authored by Tomasz Unger's avatar Tomasz Unger Committed by Jakub Kicinski
Browse files

NFC: pn544: i2c: Replace strcpy() with strscpy() 



Replace strcpy() with strscpy() which limits the copy to the size of
the destination buffer. Since phy->firmware_name is an array, the
two-argument variant of strscpy() is used - the compiler deduces
the buffer size automatically.

This is a defensive cleanup. As pointed out by Jakub Kicinski
<kuba@kernel.org>, firmware_name is already bounded to
NFC_FIRMWARE_NAME_MAXSIZE via nla_strscpy() in net/nfc/netlink.c
before reaching this driver, so no actual buffer overflow is possible.

Signed-off-by: default avatarTomasz Unger <tomasz.unger@yahoo.pl>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260301121254.174354-1-tomasz.unger@yahoo.pl


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ed0abfe9

drivers/nfc/pn544/i2c.c

+1 −1
Original line number Diff line number Diff line
@@ -526,7 +526,7 @@ static int pn544_hci_i2c_fw_download(void *phy_id, const char *firmware_name, 


	pr_info("Starting Firmware Download (%s)\n", firmware_name);



	strcpy(phy->firmware_name, firmware_name);

	strscpy(phy->firmware_name, firmware_name);



	phy->hw_variant = hw_variant;

	phy->fw_work_state = FW_WORK_STATE_START;