Commit e64285ff authored by Dmitry Antipov's avatar Dmitry Antipov Committed by Jakub Kicinski
Browse files

rocker: fix link status detection in rocker_carrier_init() 



Since '1 << rocker_port->pport' may be undefined for port >= 32,
cast the left operand to 'unsigned long long' like it's done in
'rocker_port_set_enable()' above. Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarDmitry Antipov <dmantipov@yandex.ru>
Link: https://patch.msgid.link/20241114151946.519047-1-dmantipov@yandex.ru


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a0c80d51

drivers/net/ethernet/rocker/rocker_main.c

+1 −1
Original line number Diff line number Diff line
@@ -2502,7 +2502,7 @@ static void rocker_carrier_init(const struct rocker_port *rocker_port) 
	u64 link_status = rocker_read64(rocker, PORT_PHYS_LINK_STATUS);

	bool link_up;



	link_up = link_status & (1 << rocker_port->pport);

	link_up = link_status & (1ULL << rocker_port->pport);

	if (link_up)

		netif_carrier_on(rocker_port->dev);

	else