Commit e64c0ff0 authored by Hui Wang's avatar Hui Wang Committed by Linus Walleij
Browse files

pinctrl: imx: Return NULL if no group is matched and found 



Currently if no group is matched and found, this function will return
the last grp to the caller, this is not expected, it is supposed to
return NULL in this case.

Fixes: e566fc11 ("pinctrl: imx: use generic pinctrl helpers for managing groups")
Signed-off-by: default avatarHui Wang <hui.wang@canonical.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/20250327031600.99723-1-hui.wang@canonical.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 0af2f6be

drivers/pinctrl/freescale/pinctrl-imx.c

+3 −3
Original line number Diff line number Diff line
@@ -37,16 +37,16 @@ static inline const struct group_desc *imx_pinctrl_find_group_by_name( 
				struct pinctrl_dev *pctldev,

				const char *name)

{

	const struct group_desc *grp = NULL;

	const struct group_desc *grp;

	int i;



	for (i = 0; i < pctldev->num_groups; i++) {

		grp = pinctrl_generic_get_group(pctldev, i);

		if (grp && !strcmp(grp->grp.name, name))

			break;

			return grp;

	}



	return grp;

	return NULL;

}



static void imx_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,