Commit e64e6ca9 authored by Ye Bin's avatar Ye Bin Committed by Theodore Ts'o
Browse files

ext4: adjust fast commit disable judgement order in ext4_fc_track_inode 



If fastcommit is already disabled, there isn't need to mark inode ineligible.
So move 'ext4_fc_disabled()' judgement bofore 'ext4_should_journal_data(inode)'
judgement which can avoid to do meaningless judgement.

Signed-off-by: default avatarYe Bin <yebin10@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220916083836.388347-3-yebin10@huawei.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent b7b80a35

fs/ext4/fast_commit.c

+3 −3
Original line number Diff line number Diff line
@@ -577,15 +577,15 @@ void ext4_fc_track_inode(handle_t *handle, struct inode *inode) 
	if (S_ISDIR(inode->i_mode))

		return;



	if (ext4_fc_disabled(inode->i_sb))

		return;



	if (ext4_should_journal_data(inode)) {

		ext4_fc_mark_ineligible(inode->i_sb,

					EXT4_FC_REASON_INODE_JOURNAL_DATA, handle);

		return;

	}



	if (ext4_fc_disabled(inode->i_sb))

		return;



	if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE))

		return;