Commit e6625db6 authored by Zijun Hu's avatar Zijun Hu Committed by Vinod Koul
Browse files

phy: core: Simplify API of_phy_simple_xlate() implementation 



Simplify of_phy_simple_xlate() implementation by API
class_find_device_by_of_node().

Also correct comments to mark its parameter @dev as unused instead of
@args in passing.

Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Cc: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20241213-phy_core_fix-v6-6-40ae28f5015a@quicinc.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent b6096751

drivers/phy/phy-core.c

+8 −15
Original line number Diff line number Diff line
@@ -744,8 +744,8 @@ EXPORT_SYMBOL_GPL(devm_phy_put); 


/**

 * of_phy_simple_xlate() - returns the phy instance from phy provider

 * @dev: the PHY provider device

 * @args: of_phandle_args (not used here)

 * @dev: the PHY provider device (not used here)

 * @args: of_phandle_args

 *

 * Intended to be used by phy provider for the common case where #phy-cells is

 * 0. For other cases where #phy-cells is greater than '0', the phy provider
@@ -755,21 +755,14 @@ EXPORT_SYMBOL_GPL(devm_phy_put); 
struct phy *of_phy_simple_xlate(struct device *dev,

				const struct of_phandle_args *args)

{

	struct phy *phy;

	struct class_dev_iter iter;



	class_dev_iter_init(&iter, &phy_class, NULL, NULL);

	while ((dev = class_dev_iter_next(&iter))) {

		phy = to_phy(dev);

		if (args->np != phy->dev.of_node)

			continue;

	struct device *target_dev;



		class_dev_iter_exit(&iter);

		return phy;

	}



	class_dev_iter_exit(&iter);

	target_dev = class_find_device_by_of_node(&phy_class, args->np);

	if (!target_dev)

		return ERR_PTR(-ENODEV);



	put_device(target_dev);

	return to_phy(target_dev);

}

EXPORT_SYMBOL_GPL(of_phy_simple_xlate);