Commit e66705de authored by Nuno Sá's avatar Nuno Sá Committed by Guenter Roeck
Browse files

hwmon: (axi-fan-control) Handle irqs in natural order 



The core will now start out of reset at boot as soon as clocking is
available. Hence, by the time we unmask the interrupts we already might
have some of them set. Thus, it's important to handle them in the
natural order the core generates them. Otherwise, we could process
'ADI_IRQ_SRC_PWM_CHANGED' before 'ADI_IRQ_SRC_TEMP_INCREASE' and
erroneously set 'update_tacho_params' to true.

Signed-off-by: default avatarNuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210811114853.159298-3-nuno.sa@analog.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a3933625

drivers/hwmon/axi-fan-control.c

+15 −15
Original line number Diff line number Diff line
@@ -283,18 +283,9 @@ static irqreturn_t axi_fan_control_irq_handler(int irq, void *data) 
	u32 irq_pending = axi_ioread(ADI_REG_IRQ_PENDING, ctl);

	u32 clear_mask;



	if (irq_pending & ADI_IRQ_SRC_NEW_MEASUR) {

		if (ctl->update_tacho_params) {

			u32 new_tach = axi_ioread(ADI_REG_TACH_MEASUR, ctl);



			/* get 25% tolerance */

			u32 tach_tol = DIV_ROUND_CLOSEST(new_tach * 25, 100);

			/* set new tacho parameters */

			axi_iowrite(new_tach, ADI_REG_TACH_PERIOD, ctl);

			axi_iowrite(tach_tol, ADI_REG_TACH_TOLERANCE, ctl);

			ctl->update_tacho_params = false;

		}

	}

	if (irq_pending & ADI_IRQ_SRC_TEMP_INCREASE)

		/* hardware requested a new pwm */

		ctl->hw_pwm_req = true;



	if (irq_pending & ADI_IRQ_SRC_PWM_CHANGED) {

		/*
@@ -310,9 +301,18 @@ static irqreturn_t axi_fan_control_irq_handler(int irq, void *data) 
		}

	}



	if (irq_pending & ADI_IRQ_SRC_TEMP_INCREASE)

		/* hardware requested a new pwm */

		ctl->hw_pwm_req = true;

	if (irq_pending & ADI_IRQ_SRC_NEW_MEASUR) {

		if (ctl->update_tacho_params) {

			u32 new_tach = axi_ioread(ADI_REG_TACH_MEASUR, ctl);

			/* get 25% tolerance */

			u32 tach_tol = DIV_ROUND_CLOSEST(new_tach * 25, 100);



			/* set new tacho parameters */

			axi_iowrite(new_tach, ADI_REG_TACH_PERIOD, ctl);

			axi_iowrite(tach_tol, ADI_REG_TACH_TOLERANCE, ctl);

			ctl->update_tacho_params = false;

		}

	}



	if (irq_pending & ADI_IRQ_SRC_TACH_ERR)

		ctl->fan_fault = 1;