Commit e6854be4 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

selftests: drv-net: tso: make bkg() wait for socat to quit 



Commit 846742f7 ("selftests: drv-net: add a warning for
bkg + shell + terminate") added a warning for bkg() used
with terminate=True. The tso test was missed as we didn't
have it running anywhere in NIPA. Add exit_wait=True, to avoid:

  # Warning: combining shell and terminate is risky!
  #          SIGTERM may not reach the child on zsh/ksh!

getting printed twice for every variant.

Fixes: 0d0f4174 ("selftests: drv-net: add a simple TSO test")
Reviewed-by: default avatarWillem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250604012055.891431-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c68804c9

tools/testing/selftests/drivers/net/hw/tso.py

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ def run_one_stream(cfg, ipver, remote_v4, remote_v6, should_lso): 
    port = rand_port()

    listen_cmd = f"socat -{ipver} -t 2 -u TCP-LISTEN:{port},reuseport /dev/null,ignoreeof"



    with bkg(listen_cmd, host=cfg.remote) as nc:

    with bkg(listen_cmd, host=cfg.remote, exit_wait=True) as nc:

        wait_port_listen(port, host=cfg.remote)



        if ipver == "4":