Commit e6a3fc4f authored by Andrew Jones's avatar Andrew Jones Committed by Thomas Gleixner
Browse files

genirq/msi: Prevent NULL pointer dereference in msi_domain_debug_show() 



irq_domain_debug_show_one() calls msi_domain_debug_show() with a non-NULL
domain pointer and a NULL irq_data pointer. irq_debug_show_data() calls it
with a NULL domain pointer.

The domain pointer is not used, but the irq_data pointer is required to be
non-NULL and lacks a NULL pointer check.

Add the missing NULL pointer check to ensure there is a non-NULL irq_data
pointer in msi_domain_debug_show() before dereferencing it.

[ tglx: Massaged change log ]

Fixes: 01499ae6 ("genirq/msi: Expose MSI message data in debugfs")
Signed-off-by: default avatarAndrew Jones <ajones@ventanamicro.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250430124836.49964-2-ajones@ventanamicro.com
parent b4432656

kernel/irq/msi.c

+1 −1
Original line number Diff line number Diff line
@@ -761,7 +761,7 @@ static int msi_domain_translate(struct irq_domain *domain, struct irq_fwspec *fw 
static void msi_domain_debug_show(struct seq_file *m, struct irq_domain *d,

				  struct irq_data *irqd, int ind)

{

	struct msi_desc *desc = irq_data_get_msi_desc(irqd);

	struct msi_desc *desc = irqd ? irq_data_get_msi_desc(irqd) : NULL;



	if (!desc)

		return;