Commit e6e3e002 authored by Marc Zyngier's avatar Marc Zyngier
Browse files

KVM: arm64: timer: Drop warning on failed interrupt signalling 



We currently spit out a warning if making a timer interrupt pending
fails. But not only this is loud and easy to trigger from userspace,
we also fail to do anything useful with that information.

Dropping the warning is the easiest thing to do for now. We can
always add error reporting if we really want in the future.

Reported-by: default avatarAlexander Potapenko <glider@google.com>
Reviewed-by: default avatarOliver Upton <oliver.upton@linux.dev>
Link: https://lore.kernel.org/r/20250212182558.2865232-2-maz@kernel.org


Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
parent b938731e

arch/arm64/kvm/arch_timer.c

+7 −9
Original line number Diff line number Diff line
@@ -447,21 +447,19 @@ static void kvm_timer_update_status(struct arch_timer_context *ctx, bool level) 
static void kvm_timer_update_irq(struct kvm_vcpu *vcpu, bool new_level,

				 struct arch_timer_context *timer_ctx)

{

	int ret;



	kvm_timer_update_status(timer_ctx, new_level);



	timer_ctx->irq.level = new_level;

	trace_kvm_timer_update_irq(vcpu->vcpu_id, timer_irq(timer_ctx),

				   timer_ctx->irq.level);



	if (!userspace_irqchip(vcpu->kvm)) {

		ret = kvm_vgic_inject_irq(vcpu->kvm, vcpu,

	if (userspace_irqchip(vcpu->kvm))

		return;



	kvm_vgic_inject_irq(vcpu->kvm, vcpu,

			    timer_irq(timer_ctx),

			    timer_ctx->irq.level,

			    timer_ctx);

		WARN_ON(ret);

	}

}



/* Only called for a fully emulated timer */