Commit e6f3dac9 authored by Gabor Juhos's avatar Gabor Juhos Committed by Bjorn Andersson
Browse files

firmware: qcom_scm: remove IS_ERR() checks from qcom_scm_bw_{en,dis}able() 



Since the qcom_scm_probe() function returns with an error if
__scm->path contains an error pointer, it is not needed to
verify that again in the qcom_scm_bw_{en,dis}able() functions
so remove the superfluous IS_ERR() checks.

Signed-off-by: default avatarGabor Juhos <j4g8y7@gmail.com>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20240308-qcom_scm-is_err-check-v1-1-9c3e1ceefafe@gmail.com


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 0c50b7fc

drivers/firmware/qcom/qcom_scm.c

+1 −4
Original line number Diff line number Diff line
@@ -163,9 +163,6 @@ static int qcom_scm_bw_enable(void) 
	if (!__scm->path)

		return 0;



	if (IS_ERR(__scm->path))

		return -EINVAL;



	mutex_lock(&__scm->scm_bw_lock);

	if (!__scm->scm_vote_count) {

		ret = icc_set_bw(__scm->path, 0, UINT_MAX);
@@ -183,7 +180,7 @@ static int qcom_scm_bw_enable(void) 


static void qcom_scm_bw_disable(void)

{

	if (IS_ERR_OR_NULL(__scm->path))

	if (!__scm->path)

		return;



	mutex_lock(&__scm->scm_bw_lock);