Commit e7080665 authored by Robin Murphy's avatar Robin Murphy Committed by Joerg Roedel
Browse files

iommu: Clean up open-coded ownership checks 



Some drivers already implement their own defence against the possibility
of being given someone else's device. Since this is now taken care of by
the core code (and via a slightly different path from the original
fwspec-based idea), let's clean them up.

Acked-by: default avatarWill Deacon <will@kernel.org>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Reviewed-by: default avatarJerry Snitselaar <jsnitsel@redhat.com>
Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/58a9879ce3f03562bb061e6714fe6efb554c3907.1700589539.git.robin.murphy@arm.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 17de3f5f

drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c

+0 −3
Original line number Diff line number Diff line
@@ -2649,9 +2649,6 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev) 
	struct arm_smmu_master *master;

	struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);



	if (!fwspec || fwspec->ops != &arm_smmu_ops)

		return ERR_PTR(-ENODEV);



	if (WARN_ON_ONCE(dev_iommu_priv_get(dev)))

		return ERR_PTR(-EBUSY);

drivers/iommu/arm/arm-smmu/arm-smmu.c

+1 −8
Original line number Diff line number Diff line
@@ -1116,11 +1116,6 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) 
	struct arm_smmu_device *smmu;

	int ret;



	if (!fwspec || fwspec->ops != &arm_smmu_ops) {

		dev_err(dev, "cannot attach to SMMU, is it on the same bus?\n");

		return -ENXIO;

	}



	/*

	 * FIXME: The arch/arm DMA API code tries to attach devices to its own

	 * domains between of_xlate() and probe_device() - we have no way to cope
@@ -1357,10 +1352,8 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev) 
		fwspec = dev_iommu_fwspec_get(dev);

		if (ret)

			goto out_free;

	} else if (fwspec && fwspec->ops == &arm_smmu_ops) {

		smmu = arm_smmu_get_by_fwnode(fwspec->iommu_fwnode);

	} else {

		return ERR_PTR(-ENODEV);

		smmu = arm_smmu_get_by_fwnode(fwspec->iommu_fwnode);

	}



	ret = -EINVAL;

drivers/iommu/arm/arm-smmu/qcom_iommu.c

+3 −13
Original line number Diff line number Diff line
@@ -79,16 +79,6 @@ static struct qcom_iommu_domain *to_qcom_iommu_domain(struct iommu_domain *dom) 


static const struct iommu_ops qcom_iommu_ops;



static struct qcom_iommu_dev * to_iommu(struct device *dev)

{

	struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);



	if (!fwspec || fwspec->ops != &qcom_iommu_ops)

		return NULL;



	return dev_iommu_priv_get(dev);

}



static struct qcom_iommu_ctx * to_ctx(struct qcom_iommu_domain *d, unsigned asid)

{

	struct qcom_iommu_dev *qcom_iommu = d->iommu;
@@ -372,7 +362,7 @@ static void qcom_iommu_domain_free(struct iommu_domain *domain) 


static int qcom_iommu_attach_dev(struct iommu_domain *domain, struct device *dev)

{

	struct qcom_iommu_dev *qcom_iommu = to_iommu(dev);

	struct qcom_iommu_dev *qcom_iommu = dev_iommu_priv_get(dev);

	struct qcom_iommu_domain *qcom_domain = to_qcom_iommu_domain(domain);

	int ret;
@@ -404,7 +394,7 @@ static int qcom_iommu_identity_attach(struct iommu_domain *identity_domain, 
	struct iommu_domain *domain = iommu_get_domain_for_dev(dev);

	struct qcom_iommu_domain *qcom_domain;

	struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);

	struct qcom_iommu_dev *qcom_iommu = to_iommu(dev);

	struct qcom_iommu_dev *qcom_iommu = dev_iommu_priv_get(dev);

	unsigned int i;



	if (domain == identity_domain || !domain)
@@ -535,7 +525,7 @@ static bool qcom_iommu_capable(struct device *dev, enum iommu_cap cap) 


static struct iommu_device *qcom_iommu_probe_device(struct device *dev)

{

	struct qcom_iommu_dev *qcom_iommu = to_iommu(dev);

	struct qcom_iommu_dev *qcom_iommu = dev_iommu_priv_get(dev);

	struct device_link *link;



	if (!qcom_iommu)

drivers/iommu/mtk_iommu.c

+1 −6
Original line number Diff line number Diff line
@@ -863,16 +863,11 @@ static phys_addr_t mtk_iommu_iova_to_phys(struct iommu_domain *domain, 
static struct iommu_device *mtk_iommu_probe_device(struct device *dev)

{

	struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);

	struct mtk_iommu_data *data;

	struct mtk_iommu_data *data = dev_iommu_priv_get(dev);

	struct device_link *link;

	struct device *larbdev;

	unsigned int larbid, larbidx, i;



	if (!fwspec || fwspec->ops != &mtk_iommu_ops)

		return ERR_PTR(-ENODEV); /* Not a iommu client device */



	data = dev_iommu_priv_get(dev);



	if (!MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM))

		return &data->iommu;

drivers/iommu/mtk_iommu_v1.c

+0 −3
Original line number Diff line number Diff line
@@ -481,9 +481,6 @@ static struct iommu_device *mtk_iommu_v1_probe_device(struct device *dev) 
		idx++;

	}



	if (!fwspec || fwspec->ops != &mtk_iommu_v1_ops)

		return ERR_PTR(-ENODEV); /* Not a iommu client device */



	data = dev_iommu_priv_get(dev);



	/* Link the consumer device with the smi-larb device(supplier) */