Unverified Commit e769779c authored by Bart Van Assche's avatar Bart Van Assche Committed by Christian Brauner
Browse files

fs: Verify write lifetime constants at compile time 



The code in fs/fcntl.c converts RWH_* constants to and from WRITE_LIFE_*
constants using casts. Verify at compile time that these casts will yield
the intended effect.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Suggested-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240202203926.2478590-3-bvanassche@acm.org


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent ec16b147

fs/fcntl.c

+7 −0
Original line number Diff line number Diff line
@@ -270,6 +270,13 @@ static int f_getowner_uids(struct file *filp, unsigned long arg) 


static bool rw_hint_valid(u64 hint)

{

	BUILD_BUG_ON(WRITE_LIFE_NOT_SET != RWH_WRITE_LIFE_NOT_SET);

	BUILD_BUG_ON(WRITE_LIFE_NONE != RWH_WRITE_LIFE_NONE);

	BUILD_BUG_ON(WRITE_LIFE_SHORT != RWH_WRITE_LIFE_SHORT);

	BUILD_BUG_ON(WRITE_LIFE_MEDIUM != RWH_WRITE_LIFE_MEDIUM);

	BUILD_BUG_ON(WRITE_LIFE_LONG != RWH_WRITE_LIFE_LONG);

	BUILD_BUG_ON(WRITE_LIFE_EXTREME != RWH_WRITE_LIFE_EXTREME);



	switch (hint) {

	case RWH_WRITE_LIFE_NOT_SET:

	case RWH_WRITE_LIFE_NONE: