Commit e7901296 authored by Alessandro Ratti's avatar Alessandro Ratti Committed by Jakub Kicinski
Browse files

selftests: rtnetlink: skip tests if tools or feats are missing 



Some rtnetlink selftests assume the presence of ifconfig and iproute2
support for the `proto` keyword in `ip address` commands. These
assumptions can cause test failures on modern systems (e.g. Debian
Bookworm) where:

 - ifconfig is not installed by default
 - The iproute2 version lacks support for address protocol

This patch improves test robustness by:

 - Skipping kci_test_promote_secondaries if ifconfig is missing
 - Skipping do_test_address_proto if ip address help does not mention
   proto

These changes ensure the tests degrade gracefully by reporting SKIP
instead of FAIL when prerequisites are not met, improving portability
across systems.

Reviewed-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Signed-off-by: default avatarAlessandro Ratti <alessandro@0x65c.net>
Link: https://patch.msgid.link/20250822140633.891360-2-alessandro@0x65c.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6e8e6baf

tools/testing/selftests/net/rtnetlink.sh

+11 −0
Original line number Diff line number Diff line
@@ -325,6 +325,11 @@ kci_test_addrlft() 


kci_test_promote_secondaries()

{

	run_cmd ifconfig "$devdummy"

	if [ $ret -ne 0 ]; then

		end_test "SKIP: ifconfig not installed"

		return $ksft_skip

	fi

	promote=$(sysctl -n net.ipv4.conf.$devdummy.promote_secondaries)



	sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=1
@@ -1203,6 +1208,12 @@ do_test_address_proto() 
	local ret=0

	local err



	run_cmd_grep 'proto' ip address help

	if [ $? -ne 0 ];then

		end_test "SKIP: addr proto ${what}: iproute2 too old"

		return $ksft_skip

	fi



	ip address add dev "$devdummy" "$addr3"

	check_err $?

	proto=$(address_get_proto "$addr3")