Commit e7a62edd authored by Maxime Chevallier's avatar Maxime Chevallier Committed by Jakub Kicinski
Browse files

net: phy: qcom: at803x: Use the correct bit to disable extended next page 



As noted in the blamed commit, the AR8035 and other PHYs from this
family advertise the Extended Next Page support by default, which may be
understood by some partners as this PHY being multi-gig capable.

The fix is to disable XNP advertising, which is done by setting bit 12
of the Auto-Negotiation Advertisement Register (MII_ADVERTISE).

The blamed commit incorrectly uses MDIO_AN_CTRL1_XNP, which is bit 13 as per
802.3 : 45.2.7.1 AN control register (Register 7.0)

BIT 12 in MII_ADVERTISE is wrapped by ADVERTISE_RESV, used by some
drivers such as the aquantia one. 802.3 Clause 28 defines bit 12 as
Extended Next Page ability, at least in recent versions of the standard.

Let's add a define for it and use it in the at803x driver.

Fixes: 3c51fa5d ("net: phy: ar803x: disable extended next page bit")
Signed-off-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260410171021.1277138-1-maxime.chevallier@bootlin.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2dddb34d

drivers/net/phy/qcom/at803x.c

+1 −1
Original line number Diff line number Diff line
@@ -524,7 +524,7 @@ static int at803x_config_init(struct phy_device *phydev) 
	 * behaviour but we still need to accommodate it. XNP is only needed

	 * for 10Gbps support, so disable XNP.

	 */

	return phy_modify(phydev, MII_ADVERTISE, MDIO_AN_CTRL1_XNP, 0);

	return phy_modify(phydev, MII_ADVERTISE, ADVERTISE_XNP, 0);

}



static void at803x_link_change_notify(struct phy_device *phydev)

include/uapi/linux/mii.h

+2 −1
Original line number Diff line number Diff line
@@ -82,7 +82,8 @@ 
#define ADVERTISE_100BASE4	0x0200	/* Try for 100mbps 4k packets  */

#define ADVERTISE_PAUSE_CAP	0x0400	/* Try for pause               */

#define ADVERTISE_PAUSE_ASYM	0x0800	/* Try for asymetric pause     */

#define ADVERTISE_RESV		0x1000	/* Unused...                   */

#define ADVERTISE_XNP		0x1000  /* Extended Next Page */

#define ADVERTISE_RESV		ADVERTISE_XNP /* Used to be reserved */

#define ADVERTISE_RFAULT	0x2000	/* Say we can detect faults    */

#define ADVERTISE_LPACK		0x4000	/* Ack link partners response  */

#define ADVERTISE_NPAGE		0x8000	/* Next page bit               */