Commit e7a71862 authored by Adrian Hunter's avatar Adrian Hunter Committed by Alexandre Belloni
Browse files

i3c: mipi-i3c-hci-pci: Enable IBI while runtime suspended for Intel controllers 



Intel LPSS I3C controllers can wake from runtime suspend to receive
in-band interrupts (IBIs), and they also implement the MIPI I3C HCI
Multi-Bus Instance capability.  When multiple I3C bus instances share the
same PCI wakeup, the PCI parent must coordinate runtime PM so that all
instances suspend together and their mipi-i3c-hci runtime suspend
callbacks are invoked in a consistent manner.

Enable IBI-based wakeup by setting HCI_QUIRK_RPM_IBI_ALLOWED for the
intel-lpss-i3c platform device.  Also set HCI_QUIRK_RPM_PARENT_MANAGED so
that the mipi-i3c-hci core driver expects runtime PM to be controlled by
the PCI parent rather than by individual instances.  For all Intel HCI PCI
configurations, enable the corresponding control_instance_pm flag in the
PCI driver.

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260306085338.62955-6-adrian.hunter@intel.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent e813e7e3

drivers/i3c/master/mipi-i3c-hci/core.c

+3 −1
Original line number Diff line number Diff line
@@ -1042,7 +1042,9 @@ static const struct acpi_device_id i3c_hci_acpi_match[] = { 
MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match);



static const struct platform_device_id i3c_hci_driver_ids[] = {

	{ .name = "intel-lpss-i3c", HCI_QUIRK_RPM_ALLOWED },

	{ .name = "intel-lpss-i3c", HCI_QUIRK_RPM_ALLOWED |

				    HCI_QUIRK_RPM_IBI_ALLOWED |

				    HCI_QUIRK_RPM_PARENT_MANAGED },

	{ /* sentinel */ }

};

MODULE_DEVICE_TABLE(platform, i3c_hci_driver_ids);

drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c

+3 −0
Original line number Diff line number Diff line
@@ -200,6 +200,7 @@ static const struct mipi_i3c_hci_pci_info intel_mi_1_info = { 
	.id = {0, 1},

	.instance_offset = {0, 0x400},

	.instance_count = 2,

	.control_instance_pm = true,

};



static const struct mipi_i3c_hci_pci_info intel_mi_2_info = {
@@ -209,6 +210,7 @@ static const struct mipi_i3c_hci_pci_info intel_mi_2_info = { 
	.id = {2, 3},

	.instance_offset = {0, 0x400},

	.instance_count = 2,

	.control_instance_pm = true,

};



static const struct mipi_i3c_hci_pci_info intel_si_2_info = {
@@ -218,6 +220,7 @@ static const struct mipi_i3c_hci_pci_info intel_si_2_info = { 
	.id = {2},

	.instance_offset = {0},

	.instance_count = 1,

	.control_instance_pm = true,

};



static int mipi_i3c_hci_pci_find_instance(struct mipi_i3c_hci_pci *hci, struct device *dev)