Unverified Commit e7a9a6ea authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Ilpo Järvinen
Browse files

platform/x86: adv_swbutton: Check ACPI_HANDLE() against NULL 



Every platform driver can be forced to match a device that doesn't match
its list of device IDs because of device_match_driver_override(), so
platform drivers that rely on the existence of a device's ACPI companion
object need to verify its presence.

Accordingly, add a requisite ACPI_HANDLE() check against NULL to the
platform/x86 adv_swbutton driver.

Fixes: 3d904005 ("platform/x86: add support for Advantech software defined button")
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/5115425.31r3eYUQgx@rafael.j.wysocki


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 00c97534

drivers/platform/x86/adv_swbutton.c

+5 −1
Original line number Diff line number Diff line
@@ -48,10 +48,14 @@ static int adv_swbutton_probe(struct platform_device *device) 
{

	struct adv_swbutton *button;

	struct input_dev *input;

	acpi_handle handle = ACPI_HANDLE(&device->dev);

	acpi_handle handle;

	acpi_status status;

	int error;



	handle = ACPI_HANDLE(&device->dev);

	if (!handle)

		return -ENODEV;



	button = devm_kzalloc(&device->dev, sizeof(*button), GFP_KERNEL);

	if (!button)

		return -ENOMEM;