Commit e7b631d7 authored Jan 27, 2024 by Heiner Kallweit Committed by Guenter Roeck Feb 11, 2024

hwmon: Remove I2C_CLASS_HWMON from drivers w/o detect() and address_list



Class-based I2C probing requires detect() and address_list to be
set in the I2C client driver, see checks in i2c_detect().
It's misleading to declare I2C_CLASS_HWMON support if this
precondition isn't met.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/75747c6a-d414-4b07-8f66-5a5cdddc3c36@gmail.com


Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent f7ab2d18

drivers/hwmon/adm1177.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -250,7 +250,6 @@ static const struct of_device_id adm1177_dt_ids[] = {
		MODULE_DEVICE_TABLE(of, adm1177_dt_ids);

		static struct i2c_driver adm1177_driver = {
		.class = I2C_CLASS_HWMON,
		.driver = {
		.name = "adm1177",
		.of_match_table = adm1177_dt_ids,

drivers/hwmon/ds1621.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -380,7 +380,6 @@ MODULE_DEVICE_TABLE(i2c, ds1621_id);

		/* This is the driver that will be inserted */
		static struct i2c_driver ds1621_driver = {
		.class = I2C_CLASS_HWMON,
		.driver = {
		.name = "ds1621",
		},

drivers/hwmon/ds620.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -241,7 +241,6 @@ MODULE_DEVICE_TABLE(i2c, ds620_id);

		/* This is the driver that will be inserted */
		static struct i2c_driver ds620_driver = {
		.class = I2C_CLASS_HWMON,
		.driver = {
		.name = "ds620",
		},

drivers/hwmon/ina209.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -589,7 +589,6 @@ MODULE_DEVICE_TABLE(of, ina209_of_match);

		/* This is the driver that will be inserted */
		static struct i2c_driver ina209_driver = {
		.class = I2C_CLASS_HWMON,
		.driver = {
		.name = "ina209",
		.of_match_table = of_match_ptr(ina209_of_match),

drivers/hwmon/ina238.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -629,7 +629,6 @@ static const struct of_device_id __maybe_unused ina238_of_match[] = {
		MODULE_DEVICE_TABLE(of, ina238_of_match);

		static struct i2c_driver ina238_driver = {
		.class = I2C_CLASS_HWMON,
		.driver = {
		.name = "ina238",
		.of_match_table = of_match_ptr(ina238_of_match),