Commit e7f8df0e authored by Jiri Pirko's avatar Jiri Pirko Committed by Jakub Kicinski
Browse files

dpll: move xa_erase() call in to match dpll_pin_alloc() error path order 



This is cosmetics. Move the call of xa_erase() in dpll_pin_put()
so the order of cleanup calls matches the error path of
dpll_pin_alloc().

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://lore.kernel.org/r/20240130155814.268622-1-jiri@resnulli.us


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5264ab61

drivers/dpll/dpll_core.c

+1 −1
Original line number Diff line number Diff line
@@ -560,9 +560,9 @@ void dpll_pin_put(struct dpll_pin *pin) 
{

	mutex_lock(&dpll_lock);

	if (refcount_dec_and_test(&pin->refcount)) {

		xa_erase(&dpll_pin_xa, pin->id);

		xa_destroy(&pin->dpll_refs);

		xa_destroy(&pin->parent_refs);

		xa_erase(&dpll_pin_xa, pin->id);

		dpll_pin_prop_free(&pin->prop);

		kfree(pin);

	}