Commit e80cf84b authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Herbert Xu
Browse files

crypto: qce - unregister previously registered algos in error path 



If we encounter an error when registering alorithms with the crypto
framework, we just bail out and don't unregister the ones we
successfully registered in prior iterations of the loop.

Add code that goes back over the algos and unregisters them before
returning an error from qce_register_algs().

Cc: stable@vger.kernel.org
Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 5278275c

drivers/crypto/qce/core.c

+7 −4
Original line number Diff line number Diff line
@@ -51,16 +51,19 @@ static void qce_unregister_algs(struct qce_device *qce) 
static int qce_register_algs(struct qce_device *qce)

{

	const struct qce_algo_ops *ops;

	int i, ret = -ENODEV;

	int i, j, ret = -ENODEV;



	for (i = 0; i < ARRAY_SIZE(qce_ops); i++) {

		ops = qce_ops[i];

		ret = ops->register_algs(qce);

		if (ret)

			break;

		if (ret) {

			for (j = i - 1; j >= 0; j--)

				ops->unregister_algs(qce);

			return ret;

		}

	}



	return ret;

	return 0;

}



static int qce_handle_request(struct crypto_async_request *async_req)