Commit e82b973d authored by Vitaliy Shevtsov's avatar Vitaliy Shevtsov Committed by Alex Deucher
Browse files

drm/amd/display: fix typos in several function pointer checks 



Fix several copypaste mistakes in *_disable_link_output() functions where
an improper function pointer is checked before dereference.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Signed-off-by: default avatarVitaliy Shevtsov <v.shevtsov@maxima.ru>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent f501057a

drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c

+1 −1
Original line number Diff line number Diff line
@@ -3315,7 +3315,7 @@ void dce110_disable_link_output(struct dc_link *link, 
	 * from enable/disable link output and only call edp panel control

	 * in enable_link_dp and disable_link_dp once.

	 */

	if (dmcu != NULL && dmcu->funcs->lock_phy)

	if (dmcu != NULL && dmcu->funcs->unlock_phy)

		dmcu->funcs->unlock_phy(dmcu);

	dc->link_srv->dp_trace_source_sequence(link, DPCD_SOURCE_SEQ_AFTER_DISABLE_LINK_PHY);

}

drivers/gpu/drm/amd/display/dc/hwss/dcn314/dcn314_hwseq.c

+1 −1
Original line number Diff line number Diff line
@@ -478,7 +478,7 @@ void dcn314_disable_link_output(struct dc_link *link, 
	 * from enable/disable link output and only call edp panel control

	 * in enable_link_dp and disable_link_dp once.

	 */

	if (dmcu != NULL && dmcu->funcs->lock_phy)

	if (dmcu != NULL && dmcu->funcs->unlock_phy)

		dmcu->funcs->unlock_phy(dmcu);

	dc->link_srv->dp_trace_source_sequence(link, DPCD_SOURCE_SEQ_AFTER_DISABLE_LINK_PHY);

drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c

+2 −2
Original line number Diff line number Diff line
@@ -1398,10 +1398,10 @@ void dcn32_disable_link_output(struct dc_link *link, 
	link->phy_state.symclk_state = SYMCLK_OFF_TX_OFF;



	if (signal == SIGNAL_TYPE_EDP &&

			link->dc->hwss.edp_backlight_control &&

			link->dc->hwss.edp_power_control &&

			!link->skip_implict_edp_power_control)

		link->dc->hwss.edp_power_control(link, false);

	else if (dmcu != NULL && dmcu->funcs->lock_phy)

	else if (dmcu != NULL && dmcu->funcs->unlock_phy)

		dmcu->funcs->unlock_phy(dmcu);



	dc->link_srv->dp_trace_source_sequence(link, DPCD_SOURCE_SEQ_AFTER_DISABLE_LINK_PHY);