Unverified Commit e82bc517 authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Mark Brown
Browse files

ALSA: hda: cs35l56: Fix filename string field layout 



Change the filename field layout to:
  cs35l56-rev[-s]-dsp1-misc[-sub].[wmfw|bin]

This is to keep the same firmware file naming scheme as the
CS35L56 ASoC driver.

This is not a compatibility break because no firmware files have
been published.

The original field layout matched the ASoC driver, but the way the
ASoC driver used the wm_adsp driver config to form this filename
was bugged. Fixing the ASoC driver to use the correct wm_adsp config
strings means that the 's' flag (to indicate a secured part) has to
move to somewhere after the first '-'.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 73cfbfa9 ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Link: https://msgid.link/r/20240129162737.497-17-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 77c60722

sound/pci/hda/cs35l56_hda.c

+9 −6
Original line number Diff line number Diff line
@@ -405,16 +405,19 @@ static int cs35l56_hda_request_firmware_file(struct cs35l56_hda *cs35l56, 
	int ret = 0;



	if (system_name && amp_name)

		*filename = kasprintf(GFP_KERNEL, "%scs35l56%s-%02x-dsp1-misc-%s-%s.%s", dir,

				      cs35l56->base.secured ? "s" : "", cs35l56->base.rev,

		*filename = kasprintf(GFP_KERNEL, "%scs35l56-%02x%s-dsp1-misc-%s-%s.%s", dir,

				      cs35l56->base.rev,

				      cs35l56->base.secured ? "-s" : "",

				      system_name, amp_name, filetype);

	else if (system_name)

		*filename = kasprintf(GFP_KERNEL, "%scs35l56%s-%02x-dsp1-misc-%s.%s", dir,

				      cs35l56->base.secured ? "s" : "", cs35l56->base.rev,

		*filename = kasprintf(GFP_KERNEL, "%scs35l56-%02x%s-dsp1-misc-%s.%s", dir,

				      cs35l56->base.rev,

				      cs35l56->base.secured ? "-s" : "",

				      system_name, filetype);

	else

		*filename = kasprintf(GFP_KERNEL, "%scs35l56%s-%02x-dsp1-misc.%s", dir,

				      cs35l56->base.secured ? "s" : "", cs35l56->base.rev,

		*filename = kasprintf(GFP_KERNEL, "%scs35l56-%02x%s-dsp1-misc.%s", dir,

				      cs35l56->base.rev,

				      cs35l56->base.secured ? "-s" : "",

				      filetype);



	if (!*filename)