Commit e849ada7 authored by Alper Ak's avatar Alper Ak Committed by Greg Kroah-Hartman
Browse files

char: misc: Use IS_ERR() for filp_open() return value 



filp_open() never returns NULL, it returns either a valid pointer or an
error pointer. Using IS_ERR_OR_NULL() is unnecessary. Additionally, if
filp were NULL, PTR_ERR(NULL) would return 0, leading to a misleading
error message.

Fixes: 74d8361b ("char: misc: add test cases")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202506132058.thWZHlrb-lkp@intel.com/


Signed-off-by: default avatarAlper Ak <alperyasinak1@gmail.com>
Acked-by: default avatarThadeu Lima de Souza Cascardo <cascardo@igalia.com>
Link: https://patch.msgid.link/20251226230248.113073-1-alperyasinak1@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dad9f13d

drivers/char/misc_minor_kunit.c

+1 −1
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ static void __init miscdev_test_can_open(struct kunit *test, struct miscdevice * 
		KUNIT_FAIL(test, "failed to create node\n");



	filp = filp_open(devname, O_RDONLY, 0);

	if (IS_ERR_OR_NULL(filp))

	if (IS_ERR(filp))

		KUNIT_FAIL(test, "failed to open misc device: %ld\n", PTR_ERR(filp));

	else

		fput(filp);