Commit e8562da8 authored by Shannon Nelson's avatar Shannon Nelson Committed by Jason Gunthorpe
Browse files

pds_core: make pdsc_auxbus_dev_del() void 

Since there really is no useful return, advertising a return value
is rather misleading.  Make pdsc_auxbus_dev_del() a void function.

Link: https://patch.msgid.link/r/20250320194412.67983-2-shannon.nelson@amd.com


Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Signed-off-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 0e18a6ec

drivers/net/ethernet/amd/pds_core/auxbus.c

+1 −6
Original line number Diff line number Diff line
@@ -175,13 +175,9 @@ static struct pds_auxiliary_dev *pdsc_auxbus_dev_register(struct pdsc *cf, 
	return padev;

}



int pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf)

void pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf)

{

	struct pds_auxiliary_dev *padev;

	int err = 0;



	if (!cf)

		return -ENODEV;



	mutex_lock(&pf->config_lock);
@@ -195,7 +191,6 @@ int pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf) 
	pf->vfs[cf->vf_id].padev = NULL;



	mutex_unlock(&pf->config_lock);

	return err;

}



int pdsc_auxbus_dev_add(struct pdsc *cf, struct pdsc *pf)

drivers/net/ethernet/amd/pds_core/core.h

+1 −1
Original line number Diff line number Diff line
@@ -304,7 +304,7 @@ int pdsc_register_notify(struct notifier_block *nb); 
void pdsc_unregister_notify(struct notifier_block *nb);

void pdsc_notify(unsigned long event, void *data);

int pdsc_auxbus_dev_add(struct pdsc *cf, struct pdsc *pf);

int pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf);

void pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf);



void pdsc_process_adminq(struct pdsc_qcq *qcq);

void pdsc_work_thread(struct work_struct *work);

drivers/net/ethernet/amd/pds_core/devlink.c

+4 −2
Original line number Diff line number Diff line
@@ -56,7 +56,9 @@ int pdsc_dl_enable_set(struct devlink *dl, u32 id, 
	for (vf_id = 0; vf_id < pdsc->num_vfs; vf_id++) {

		struct pdsc *vf = pdsc->vfs[vf_id].vf;



		err = ctx->val.vbool ? pdsc_auxbus_dev_add(vf, pdsc) :

		if (ctx->val.vbool)

			err = pdsc_auxbus_dev_add(vf, pdsc);

		else

			pdsc_auxbus_dev_del(vf, pdsc);

	}