Commit e86750b0 authored by Johan Hovold's avatar Johan Hovold Committed by Abhinav Kumar
Browse files

drm/msm/dp: fix runtime PM leak on connect failure 



Make sure to balance the runtime PM usage counter (and suspend) before
returning on connect failures (e.g. DPCD read failures after a spurious
connect event or if link training fails).

Fixes: 5814b8bf ("drm/msm/dp: incorporate pm_runtime framework into DP driver")
Cc: stable@vger.kernel.org      # 6.8
Cc: Kuogee Hsieh <quic_khsieh@quicinc.com>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/582746/
Link: https://lore.kernel.org/r/20240313164306.23133-3-johan+linaro@kernel.org


Signed-off-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
parent 0640f47b

drivers/gpu/drm/msm/dp/dp_display.c

+1 −0
Original line number Diff line number Diff line
@@ -572,6 +572,7 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data) 
	ret = dp_display_usbpd_configure_cb(&pdev->dev);

	if (ret) {	/* link train failed */

		dp->hpd_state = ST_DISCONNECTED;

		pm_runtime_put_sync(&pdev->dev);

	} else {

		dp->hpd_state = ST_MAINLINK_READY;

	}