Commit e883c647 authored by Joe Hattori's avatar Joe Hattori Committed by Vinod Koul
Browse files

dmaengine: ti: edma: fix OF node reference leaks in edma_driver 



The .probe() of edma_driver calls of_parse_phandle_with_fixed_args() but
does not release the obtained OF nodes. Thus add a of_node_put() call.

This bug was found by an experimental verification tool that I am
developing.

Fixes: 1be5336b ("dmaengine: edma: New device tree binding")
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241219020507.1983124-3-joe@pf.is.s.u-tokyo.ac.jp


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 0ab43318

drivers/dma/ti/edma.c

+1 −2
Original line number Diff line number Diff line
@@ -208,7 +208,6 @@ struct edma_desc { 
struct edma_cc;



struct edma_tc {

	struct device_node		*node;

	u16				id;

};
@@ -2466,13 +2465,13 @@ static int edma_probe(struct platform_device *pdev) 
			if (ret)

				break;



			ecc->tc_list[i].node = tc_args.np;

			ecc->tc_list[i].id = i;

			queue_priority_mapping[i][1] = tc_args.args[0];

			if (queue_priority_mapping[i][1] > lowest_priority) {

				lowest_priority = queue_priority_mapping[i][1];

				info->default_queue = i;

			}

			of_node_put(tc_args.np);

		}



		/* See if we have optional dma-channel-mask array */