Commit e8866e26 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Damien Le Moal
Browse files

ata: libata-core: Simplify ata_print_version_once 



Use dev_dbg_once() instead of open-coding the once functionality.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent 9d7a0577

drivers/ata/libata-core.c

+0 −6
Original line number Diff line number Diff line
@@ -6682,12 +6682,6 @@ const struct ata_port_info ata_dummy_port_info = { 
};

EXPORT_SYMBOL_GPL(ata_dummy_port_info);



void ata_print_version(const struct device *dev, const char *version)

{

	dev_printk(KERN_DEBUG, dev, "version %s\n", version);

}

EXPORT_SYMBOL(ata_print_version);



EXPORT_TRACEPOINT_SYMBOL_GPL(ata_tf_load);

EXPORT_TRACEPOINT_SYMBOL_GPL(ata_exec_command);

EXPORT_TRACEPOINT_SYMBOL_GPL(ata_bmdma_setup);

include/linux/libata.h

+5 −12
Original line number Diff line number Diff line
@@ -41,17 +41,6 @@ 
 */

#undef ATA_IRQ_TRAP		/* define to ack screaming irqs */





#define ata_print_version_once(dev, version)			\

({								\

	static bool __print_once;				\

								\

	if (!__print_once) {					\

		__print_once = true;				\

		ata_print_version(dev, version);		\

	}							\

})



/* defines only for the constants which don't work well as enums */

#define ATA_TAG_POISON		0xfafbfcfdU
@@ -1593,7 +1582,11 @@ do { \ 
#define ata_dev_dbg(dev, fmt, ...)				\

	ata_dev_printk(debug, dev, fmt, ##__VA_ARGS__)



void ata_print_version(const struct device *dev, const char *version);

static inline void ata_print_version_once(const struct device *dev,

					  const char *version)

{

	dev_dbg_once(dev, "version %s\n", version);

}



/*

 * ata_eh_info helpers