Commit e8b7d11c authored by Markus Elfring's avatar Markus Elfring Committed by Miquel Raynal
Browse files

mtd: ssfdc: One function call less in ssfdcr_add_mtd() after error detection 



The kfree() function was called in one case by
the ssfdcr_add_mtd() function during error handling
even if the passed data structure member contained a null pointer.
This issue was detected by using the Coccinelle software.

Thus use another label.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/56d92e42-db9e-4767-bcb1-9686bdf34a03@web.de
parent 8d55a90b

drivers/mtd/ssfdc.c

+2 −1
Original line number Diff line number Diff line
@@ -332,7 +332,7 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) 
		kmalloc_array(ssfdc->map_len,

			      sizeof(ssfdc->logic_block_map[0]), GFP_KERNEL);

	if (!ssfdc->logic_block_map)

		goto out_err;

		goto out_free_ssfdc;

	memset(ssfdc->logic_block_map, 0xff, sizeof(ssfdc->logic_block_map[0]) *

		ssfdc->map_len);
@@ -350,6 +350,7 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) 


out_err:

	kfree(ssfdc->logic_block_map);

out_free_ssfdc:

        kfree(ssfdc);

}