Commit e8e4a470 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Helge Deller
Browse files

fbdev: core: syscopyarea: fix sloppy typing 



In sys_copyarea(), the local variable bits_per_line is needlessly typed as
*unsigned long* -- which is a 32-bit type on the 32-bit arches and a 64-bit
type on the 64-bit arches; that variable's value is derived from the __u32
typed fb_fix_screeninfo::line_length field (multiplied by 8u) and a 32-bit
*unsigned int* type should still be enough to store the # of bits per line.

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 7f33df94

drivers/video/fbdev/core/syscopyarea.c

+1 −1
Original line number Diff line number Diff line
@@ -316,7 +316,7 @@ void sys_copyarea(struct fb_info *p, const struct fb_copyarea *area) 
{

	u32 dx = area->dx, dy = area->dy, sx = area->sx, sy = area->sy;

	u32 height = area->height, width = area->width;

	unsigned long const bits_per_line = p->fix.line_length*8u;

	unsigned int const bits_per_line = p->fix.line_length * 8u;

	unsigned long *base = NULL;

	int bits = BITS_PER_LONG, bytes = bits >> 3;

	unsigned dst_idx = 0, src_idx = 0, rev_copy = 0;