Commit e8f0dc02 authored by Marek Behún's avatar Marek Behún Committed by Jakub Kicinski
Browse files

net: dsa: realtek: Fix LED group port bit for non-zero LED group 



The rtl8366rb_led_group_port_mask() function always returns LED port
bit in LED group 0; the switch statement returns the same thing in all
non-default cases.

This means that the driver does not currently support configuring LEDs
in non-zero LED groups.

Fix this.

Fixes: 32d61700 ("net: dsa: realtek: add LED drivers for rtl8366rb")
Signed-off-by: default avatarMarek Behún <kabel@kernel.org>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260311111237.29002-1-kabel@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6c5a9baa

drivers/net/dsa/realtek/rtl8366rb-leds.c

+3 −3
Original line number Diff line number Diff line
@@ -12,11 +12,11 @@ static inline u32 rtl8366rb_led_group_port_mask(u8 led_group, u8 port) 
	case 0:

		return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));

	case 1:

		return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));

		return FIELD_PREP(RTL8366RB_LED_X_1_CTRL_MASK, BIT(port));

	case 2:

		return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));

		return FIELD_PREP(RTL8366RB_LED_2_X_CTRL_MASK, BIT(port));

	case 3:

		return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));

		return FIELD_PREP(RTL8366RB_LED_X_3_CTRL_MASK, BIT(port));

	default:

		return 0;

	}