Commit e8f45927 authored by Vishal Annapurve's avatar Vishal Annapurve Committed by Ingo Molnar
Browse files

x86/tdx: Emit warning if IRQs are enabled during HLT #VE handling 



Direct HLT instruction execution causes #VEs for TDX VMs which is routed
to hypervisor via TDCALL. safe_halt() routines execute HLT in STI-shadow
so IRQs need to remain disabled until the TDCALL to ensure that pending
IRQs are correctly treated as wake events.

Emit warning and fail emulation if IRQs are enabled during HLT #VE handling
to avoid running into scenarios where IRQ wake events are lost resulting in
indefinite HLT execution times.

Signed-off-by: default avatarVishal Annapurve <vannapurve@google.com>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Tested-by: default avatarRyan Afranji <afranji@google.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lore.kernel.org/r/20250228014416.3925664-4-vannapurve@google.com
parent 9f98a4f4

arch/x86/coco/tdx/tdx.c

+8 −0
Original line number Diff line number Diff line
@@ -393,6 +393,14 @@ static int handle_halt(struct ve_info *ve) 
{

	const bool irq_disabled = irqs_disabled();



	/*

	 * HLT with IRQs enabled is unsafe, as an IRQ that is intended to be a

	 * wake event may be consumed before requesting HLT emulation, leaving

	 * the vCPU blocking indefinitely.

	 */

	if (WARN_ONCE(!irq_disabled, "HLT emulation with IRQs enabled"))

		return -EIO;



	if (__halt(irq_disabled))

		return -EIO;