Commit e93bb4b7 authored by Jiaxun Yang's avatar Jiaxun Yang Committed by Thomas Bogendoerfer
Browse files

MIPS: rb532: Fix MMIO UART resource registration 



Since commit 6e690d54 ("serial: 8250: fix return error code in
serial8250_request_std_resource()"), registering an 8250 MMIO port
without mapbase no longer works, as the resource range is derived from
mapbase/mapsize.

Populate mapbase and mapsize accordingly. Also drop ugly membase KSEG1
pointer and set UPF_IOREMAP instead, letting the 8250 core perform the
ioremap.

Fixes: 6e690d54 ("serial: 8250: fix return error code in serial8250_request_std_resource()")
Cc: stable@vger.kernel.org
Reported-by: default avatarWaldemar Brodkorb <wbx@openadk.org>
Link: https://lore.kernel.org/linux-mips/aX-d0ShTplHKZT33@waldemar-brodkorb.de/


Signed-off-by: default avatarJiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 30bfc2d6

arch/mips/rb532/devices.c

+3 −2
Original line number Diff line number Diff line
@@ -212,11 +212,12 @@ static struct platform_device rb532_wdt = { 
static struct plat_serial8250_port rb532_uart_res[] = {

	{

		.type           = PORT_16550A,

		.membase	= (char *)KSEG1ADDR(REGBASE + UART0BASE),

		.mapbase        = REGBASE + UART0BASE,

		.mapsize        = 0x1000,

		.irq		= UART0_IRQ,

		.regshift	= 2,

		.iotype		= UPIO_MEM,

		.flags		= UPF_BOOT_AUTOCONF,

		.flags		= UPF_BOOT_AUTOCONF | UPF_IOREMAP,

	},

	{

		.flags		= 0,