Commit e965e771 authored by Ma Ke's avatar Ma Ke Committed by Alain Volmat
Browse files

drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check 



The return value of drm_atomic_get_crtc_state() needs to be
checked. To avoid use of error pointer 'crtc_state' in case
of the failure.

Cc: stable@vger.kernel.org
Fixes: dd86dc2f ("drm/sti: implement atomic_check for the planes")
Signed-off-by: default avatarMa Ke <make24@iscas.ac.cn>
Acked-by: default avatarAlain Volmat <alain.volmat@foss.st.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240909063359.1197065-1-make24@iscas.ac.cn


Signed-off-by: default avatarAlain Volmat <alain.volmat@foss.st.com>
parent c1ab40a1

drivers/gpu/drm/sti/sti_gdp.c

+3 −0
Original line number Diff line number Diff line
@@ -638,6 +638,9 @@ static int sti_gdp_atomic_check(struct drm_plane *drm_plane, 


	mixer = to_sti_mixer(crtc);

	crtc_state = drm_atomic_get_crtc_state(state, crtc);

	if (IS_ERR(crtc_state))

		return PTR_ERR(crtc_state);



	mode = &crtc_state->mode;

	dst_x = new_plane_state->crtc_x;

	dst_y = new_plane_state->crtc_y;