Unverified Commit e97d06a4 authored by Christian Brauner's avatar Christian Brauner
Browse files

bdev: remove bdev_open_by_path() 

Link: https://lore.kernel.org/r/20240123-vfs-bdev-file-v2-27-adbd023e19cc@kernel.org


Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 9de31ee6

block/bdev.c

+0 −40
Original line number Diff line number Diff line
@@ -1004,46 +1004,6 @@ struct file *bdev_file_open_by_path(const char *path, blk_mode_t mode, 
}

EXPORT_SYMBOL(bdev_file_open_by_path);



/**

 * bdev_open_by_path - open a block device by name

 * @path: path to the block device to open

 * @mode: open mode (BLK_OPEN_*)

 * @holder: exclusive holder identifier

 * @hops: holder operations

 *

 * Open the block device described by the device file at @path.  If @holder is

 * not %NULL, the block device is opened with exclusive access.  Exclusive opens

 * may nest for the same @holder.

 *

 * CONTEXT:

 * Might sleep.

 *

 * RETURNS:

 * Handle with a reference to the block_device on success, ERR_PTR(-errno) on

 * failure.

 */

struct bdev_handle *bdev_open_by_path(const char *path, blk_mode_t mode,

		void *holder, const struct blk_holder_ops *hops)

{

	struct bdev_handle *handle;

	dev_t dev;

	int error;



	error = lookup_bdev(path, &dev);

	if (error)

		return ERR_PTR(error);



	handle = bdev_open_by_dev(dev, mode, holder, hops);

	if (!IS_ERR(handle) && (mode & BLK_OPEN_WRITE) &&

	    bdev_read_only(handle->bdev)) {

		bdev_release(handle);

		return ERR_PTR(-EACCES);

	}



	return handle;

}

EXPORT_SYMBOL(bdev_open_by_path);



void bdev_release(struct bdev_handle *handle)

{

	struct block_device *bdev = handle->bdev;

include/linux/blkdev.h

+0 −2
Original line number Diff line number Diff line
@@ -1484,8 +1484,6 @@ struct bdev_handle { 


struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder,

		const struct blk_holder_ops *hops);

struct bdev_handle *bdev_open_by_path(const char *path, blk_mode_t mode,

		void *holder, const struct blk_holder_ops *hops);

struct file *bdev_file_open_by_dev(dev_t dev, blk_mode_t mode, void *holder,

		const struct blk_holder_ops *hops);

struct file *bdev_file_open_by_path(const char *path, blk_mode_t mode,