Commit e97db6d9 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Alex Deucher
Browse files

drm/amd/display: use swap() in is_config_schedulable() 



Use existing swap() function rather than duplicating its implementation.

./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c:1171:103-104: WARNING opportunity for swap().
./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c:1231:99-100: WARNING opportunity for swap().

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9400


Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 68936346

drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c

+4 −7
Original line number Diff line number Diff line
@@ -1163,7 +1163,6 @@ static bool is_config_schedulable( 
	schedulable = true;



	/* sort disallow times from greatest to least */

	unsigned int temp;

	for (i = 0; i < s->pmo_dcn4.num_timing_groups; i++) {

		bool swapped = false;
@@ -1172,9 +1171,8 @@ static bool is_config_schedulable( 
			double jp1_disallow_us = s->pmo_dcn4.group_common_fams2_meta[s->pmo_dcn4.sorted_group_gtl_disallow_index[j + 1]].disallow_time_us;

			if (j_disallow_us < jp1_disallow_us) {

				/* swap as A < B */

				temp = s->pmo_dcn4.sorted_group_gtl_disallow_index[j];

				s->pmo_dcn4.sorted_group_gtl_disallow_index[j] = s->pmo_dcn4.sorted_group_gtl_disallow_index[j + 1];

				s->pmo_dcn4.sorted_group_gtl_disallow_index[j + 1] = temp;

				swap(s->pmo_dcn4.sorted_group_gtl_disallow_index[j],

				     s->pmo_dcn4.sorted_group_gtl_disallow_index[j+1]);

				swapped = true;

			}

		}
@@ -1232,9 +1230,8 @@ static bool is_config_schedulable( 
			double jp1_period_us = s->pmo_dcn4.group_common_fams2_meta[s->pmo_dcn4.sorted_group_gtl_period_index[j + 1]].period_us;

			if (j_period_us < jp1_period_us) {

				/* swap as A < B */

				temp = s->pmo_dcn4.sorted_group_gtl_period_index[j];

				s->pmo_dcn4.sorted_group_gtl_period_index[j] = s->pmo_dcn4.sorted_group_gtl_period_index[j + 1];

				s->pmo_dcn4.sorted_group_gtl_period_index[j + 1] = temp;

				swap(s->pmo_dcn4.sorted_group_gtl_period_index[j],

				     s->pmo_dcn4.sorted_group_gtl_period_index[j+1]);

				swapped = true;

			}

		}