Commit e97faa0c authored by Wei Fang's avatar Wei Fang Committed by Paolo Abeni
Browse files

net: fec: do not update PEROUT if it is enabled 



If the previously set PEROUT is already active, updating it will cause
the new PEROUT to start immediately instead of at the specified time.
This is because fep->reload_period is updated whithout check whether
the PEROUT is enabled, and the old PEROUT is not disabled. Therefore,
the pulse period will be updated immediately in the pulse interrupt
handler fec_pps_interrupt().

Currently, the driver does not support directly updating PEROUT and it
will make the logic be more complicated. To fix the current issue, add
a check before enabling the PEROUT, the driver will return an error if
PEROUT is enabled. If users wants to update a new PEROUT, they should
disable the old PEROUT first.

Fixes: 350749b9 ("net: fec: Add support for periodic output signal of PPS")
Signed-off-by: default avatarWei Fang <wei.fang@nxp.com>
Link: https://patch.msgid.link/20251125085210.1094306-3-wei.fang@nxp.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 50caa744

drivers/net/ethernet/freescale/fec.h

+1 −0
Original line number Diff line number Diff line
@@ -687,6 +687,7 @@ struct fec_enet_private { 
	unsigned int reload_period;

	int pps_enable;

	unsigned int next_counter;

	bool perout_enable;

	struct hrtimer perout_timer;

	u64 perout_stime;

drivers/net/ethernet/freescale/fec_ptp.c

+33 −10
Original line number Diff line number Diff line
@@ -243,6 +243,7 @@ static int fec_ptp_pps_perout(struct fec_enet_private *fep) 
	 * the FEC_TCCR register in time and missed the start time.

	 */

	if (fep->perout_stime < curr_time + 100 * NSEC_PER_MSEC) {

		fep->perout_enable = false;

		dev_err(&fep->pdev->dev, "Current time is too close to the start time!\n");

		spin_unlock_irqrestore(&fep->tmreg_lock, flags);

		return -1;
@@ -500,6 +501,7 @@ static int fec_ptp_pps_disable(struct fec_enet_private *fep, uint channel) 
	hrtimer_cancel(&fep->perout_timer);



	spin_lock_irqsave(&fep->tmreg_lock, flags);

	fep->perout_enable = false;

	writel(0, fep->hwp + FEC_TCSR(channel));

	spin_unlock_irqrestore(&fep->tmreg_lock, flags);
@@ -531,6 +533,8 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp, 


		return ret;

	} else if (rq->type == PTP_CLK_REQ_PEROUT) {

		u32 reload_period;



		/* Reject requests with unsupported flags */

		if (rq->perout.flags)

			return -EOPNOTSUPP;
@@ -550,12 +554,14 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp, 
			return -EOPNOTSUPP;

		}



		fep->reload_period = div_u64(period_ns, 2);

		if (on && fep->reload_period) {

		reload_period = div_u64(period_ns, 2);

		if (on && reload_period) {

			u64 perout_stime;



			/* Convert 1588 timestamp to ns*/

			start_time.tv_sec = rq->perout.start.sec;

			start_time.tv_nsec = rq->perout.start.nsec;

			fep->perout_stime = timespec64_to_ns(&start_time);

			perout_stime = timespec64_to_ns(&start_time);



			mutex_lock(&fep->ptp_clk_mutex);

			if (!fep->ptp_clk_on) {
@@ -564,18 +570,35 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp, 
				return -EOPNOTSUPP;

			}

			spin_lock_irqsave(&fep->tmreg_lock, flags);



			if (fep->perout_enable) {

				dev_err(&fep->pdev->dev,

					"PEROUT has been enabled\n");

				ret = -EBUSY;

				goto unlock;

			}



			/* Read current timestamp */

			curr_time = timecounter_read(&fep->tc);

			spin_unlock_irqrestore(&fep->tmreg_lock, flags);

			mutex_unlock(&fep->ptp_clk_mutex);

			if (perout_stime <= curr_time) {

				dev_err(&fep->pdev->dev,

					"Start time must be greater than current time\n");

				ret = -EINVAL;

				goto unlock;

			}



			/* Calculate time difference */

			delta = fep->perout_stime - curr_time;

			delta = perout_stime - curr_time;

			fep->reload_period = reload_period;

			fep->perout_stime = perout_stime;

			fep->perout_enable = true;



			if (fep->perout_stime <= curr_time) {

				dev_err(&fep->pdev->dev, "Start time must larger than current time!\n");

				return -EINVAL;

			}

unlock:

			spin_unlock_irqrestore(&fep->tmreg_lock, flags);

			mutex_unlock(&fep->ptp_clk_mutex);



			if (ret)

				return ret;



			/* Because the timer counter of FEC only has 31-bits, correspondingly,

			 * the time comparison register FEC_TCCR also only low 31 bits can be