Commit e98137f0 authored by Alex Williamson's avatar Alex Williamson Committed by Alex Williamson
Browse files

vfio/pci: Fix double free in dma-buf feature 



The error path through vfio_pci_core_feature_dma_buf() ignores its
own advice to only use dma_buf_put() after dma_buf_export(), instead
falling through the entire unwind chain.  In the unlikely event that
we encounter file descriptor exhaustion, this can result in an
unbalanced refcount on the vfio device and double free of allocated
objects.

Avoid this by moving the "put" directly into the error path and return
the errno rather than entering the unwind chain.

Reported-by: default avatarRenato Marziano <renato@marziano.top>
Fixes: 5d74781e ("vfio/pci: Add dma-buf export support for MMIO regions")
Cc: stable@vger.kernel.org
Acked-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarAlex Williamson <alex.williamson@nvidia.com>
Link: https://lore.kernel.org/r/20260323215659.2108191-3-alex.williamson@nvidia.com


Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarAlex Williamson <alex@shazbot.org>
parent 6de23f81

drivers/vfio/pci/vfio_pci_dmabuf.c

+2 −3
Original line number Diff line number Diff line
@@ -301,11 +301,10 @@ int vfio_pci_core_feature_dma_buf(struct vfio_pci_core_device *vdev, u32 flags, 
	 */

	ret = dma_buf_fd(priv->dmabuf, get_dma_buf.open_flags);

	if (ret < 0)

		goto err_dma_buf;

		dma_buf_put(priv->dmabuf);



	return ret;



err_dma_buf:

	dma_buf_put(priv->dmabuf);

err_dev_put:

	vfio_device_put_registration(&vdev->vdev);

err_free_phys: