Commit e99ecbc4 authored by Dave Jiang's avatar Dave Jiang
Browse files

acpi/hmat: Remove now unused hmat_update_target_coordinates() 



Remove deadcode since CXL no longer calls hmat_update_target_coordinates().

Reviewed-by: default avatarJonathan Cameron <jonathan.cameron@huawei.com>
Link: https://patch.msgid.link/20250829222907.1290912-5-dave.jiang@intel.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent 2e454fb8

drivers/acpi/numa/hmat.c

+0 −28
Original line number Diff line number Diff line
@@ -367,34 +367,6 @@ static void hmat_update_target_access(struct memory_target *target, 
	}

}



int hmat_update_target_coordinates(int nid, struct access_coordinate *coord,

				   enum access_coordinate_class access)

{

	struct memory_target *target;

	int pxm;



	if (nid == NUMA_NO_NODE)

		return -EINVAL;



	pxm = node_to_pxm(nid);

	guard(mutex)(&target_lock);

	target = find_mem_target(pxm);

	if (!target)

		return -ENODEV;



	hmat_update_target_access(target, ACPI_HMAT_READ_LATENCY,

				  coord->read_latency, access);

	hmat_update_target_access(target, ACPI_HMAT_WRITE_LATENCY,

				  coord->write_latency, access);

	hmat_update_target_access(target, ACPI_HMAT_READ_BANDWIDTH,

				  coord->read_bandwidth, access);

	hmat_update_target_access(target, ACPI_HMAT_WRITE_BANDWIDTH,

				  coord->write_bandwidth, access);



	return 0;

}

EXPORT_SYMBOL_GPL(hmat_update_target_coordinates);



static __init void hmat_add_locality(struct acpi_hmat_locality *hmat_loc)

{

	struct memory_locality *loc;

drivers/cxl/core/cdat.c

+0 −6
Original line number Diff line number Diff line
@@ -1075,9 +1075,3 @@ void cxl_region_perf_data_calculate(struct cxl_region *cxlr, 
		cxlr->coord[i].write_bandwidth += perf->coord[i].write_bandwidth;

	}

}
 


int cxl_update_hmat_access_coordinates(int nid, struct cxl_region *cxlr,

				       enum access_coordinate_class access)

{

	return hmat_update_target_coordinates(nid, &cxlr->coord[access], access);

}

drivers/cxl/core/core.h

+0 −2
Original line number Diff line number Diff line
@@ -137,8 +137,6 @@ enum cxl_poison_trace_type { 


long cxl_pci_get_latency(struct pci_dev *pdev);

int cxl_pci_get_bandwidth(struct pci_dev *pdev, struct access_coordinate *c);

int cxl_update_hmat_access_coordinates(int nid, struct cxl_region *cxlr,

				       enum access_coordinate_class access);

int cxl_port_get_switch_dport_bandwidth(struct cxl_port *port,

					struct access_coordinate *c);

include/linux/acpi.h

+0 −12
Original line number Diff line number Diff line
@@ -1595,18 +1595,6 @@ static inline void acpi_use_parent_companion(struct device *dev) 
	ACPI_COMPANION_SET(dev, ACPI_COMPANION(dev->parent));

}



#ifdef CONFIG_ACPI_HMAT

int hmat_update_target_coordinates(int nid, struct access_coordinate *coord,

				   enum access_coordinate_class access);

#else

static inline int hmat_update_target_coordinates(int nid,

						 struct access_coordinate *coord,

						 enum access_coordinate_class access)

{

	return -EOPNOTSUPP;

}

#endif



#ifdef CONFIG_ACPI_NUMA

bool acpi_node_backed_by_real_pxm(int nid);

#else