Commit e9c20632 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

usb: cdns3: cdnsp-pci: remove redundant pci_disable_device() call 



The cdnsp-pci driver uses pcim_enable_device() to enable a PCI device,
which means the device will be automatically disabled on driver detach
through the managed device framework. The manual pci_disable_device()
call in the error path is therefore redundant.

Found via static anlaysis and this is similar to commit 99ca0b57
("thermal: intel: int340x: processor: Fix warning during module unload").

Fixes: 3d829045 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20250903141613.2535472-1-linmq006@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1c208fd3

drivers/usb/cdns3/cdnsp-pci.c

+1 −4
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ static int cdnsp_pci_probe(struct pci_dev *pdev, 
		cdnsp = kzalloc(sizeof(*cdnsp), GFP_KERNEL);

		if (!cdnsp) {

			ret = -ENOMEM;

			goto disable_pci;

			goto put_pci;

		}

	}
@@ -168,9 +168,6 @@ static int cdnsp_pci_probe(struct pci_dev *pdev, 
	if (!pci_is_enabled(func))

		kfree(cdnsp);



disable_pci:

	pci_disable_device(pdev);



put_pci:

	pci_dev_put(func);