Commit e9c97222 authored by Adrian Hunter's avatar Adrian Hunter Committed by Ulf Hansson
Browse files

mmc: bcm2835: Remove local_irq_{save,restore}() around sg_miter_{next,stop}() 



sg_miter_next() using an sg_mapping_iter with flag SG_MITER_ATOMIC uses
kmap_atomic() to map pages.

A long time ago the kmap_atomic API required a slot to be provided which
risked the possibility that other code might use the same slot at the
same time. Disabling interrupts prevented the possibility of an interrupt
handler doing that. However, that went away with
commit 3e4d3af5 ("mm: stack based kmap_atomic()").

Remove local_irq_{save,restore}() around sg_miter_{next,stop}().

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20221005101951.3165-6-adrian.hunter@intel.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 8ff683f6

drivers/mmc/host/bcm2835.c

+0 −5
Original line number Diff line number Diff line
@@ -327,7 +327,6 @@ static void bcm2835_dma_complete(void *param) 


static void bcm2835_transfer_block_pio(struct bcm2835_host *host, bool is_read)

{

	unsigned long flags;

	size_t blksize;

	unsigned long wait_max;
@@ -335,8 +334,6 @@ static void bcm2835_transfer_block_pio(struct bcm2835_host *host, bool is_read) 


	wait_max = jiffies + msecs_to_jiffies(500);



	local_irq_save(flags);



	while (blksize) {

		int copy_words;

		u32 hsts = 0;
@@ -421,8 +418,6 @@ static void bcm2835_transfer_block_pio(struct bcm2835_host *host, bool is_read) 
	}



	sg_miter_stop(&host->sg_miter);



	local_irq_restore(flags);

}



static void bcm2835_transfer_pio(struct bcm2835_host *host)