Unverified Commit e9d5ae8a authored by Donald Robson's avatar Donald Robson Committed by Maxime Ripard
Browse files

drm/imagination: Removed unused functions in pvr_fw_trace 



Fixing the warning below due to an unused file level vtable. Removing
only this causes additional warnings for the now unused functions, so
I've removed those too.

>> drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: 'pvr_fw_trace_group_mask_fops' defined but not used [-Wunused-const-variable=]
     205 | static const struct file_operations pvr_fw_trace_group_mask_fops = {
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Changes since v1:
- Corrected hash in Fixes tag.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311302054.MVYPxFCE-lkp@intel.com/


Fixes: cb56cd61 ("drm/imagination: Add firmware trace to debugfs")
Signed-off-by: default avatarDonald Robson <donald.robson@imgtec.com>
Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231204151337.60930-1-donald.robson@imgtec.com
parent aa5d7cf8

drivers/gpu/drm/imagination/pvr_fw_trace.c

+0 −44
Original line number Diff line number Diff line
@@ -167,50 +167,6 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask) 


#if defined(CONFIG_DEBUG_FS)



static int fw_trace_group_mask_show(struct seq_file *m, void *data)

{

	struct pvr_device *pvr_dev = m->private;



	seq_printf(m, "%08x\n", pvr_dev->fw_dev.fw_trace.group_mask);



	return 0;

}



static int fw_trace_group_mask_open(struct inode *inode, struct file *file)

{

	return single_open(file, fw_trace_group_mask_show, inode->i_private);

}



static ssize_t fw_trace_group_mask_write(struct file *file, const char __user *ubuf, size_t len,

					 loff_t *offp)

{

	struct seq_file *m = file->private_data;

	struct pvr_device *pvr_dev = m->private;

	u32 new_group_mask;

	int err;



	err = kstrtouint_from_user(ubuf, len, 0, &new_group_mask);

	if (err)

		return err;



	err = update_logtype(pvr_dev, new_group_mask);

	if (err)

		return err;



	pvr_dev->fw_dev.fw_trace.group_mask = new_group_mask;



	return (ssize_t)len;

}



static const struct file_operations pvr_fw_trace_group_mask_fops = {

	.owner = THIS_MODULE,

	.open = fw_trace_group_mask_open,

	.read = seq_read,

	.write = fw_trace_group_mask_write,

	.llseek = default_llseek,

	.release = single_release,

};



struct pvr_fw_trace_seq_data {

	/** @buffer: Pointer to copy of trace data. */

	u32 *buffer;