Commit e9fda510 authored by Alex Hung's avatar Alex Hung Committed by Alex Deucher
Browse files

drm/amd/display: Removed unused assignments and variables 



[WHAT]
A number of values are assigned to variables but the stored values are
not used afterwards.

[HOW]
The assignments are removed. If the variables are not used, they are
removed as well.

This fixes 9 UNUSED_VALUE issues reported by Coverity.

Reviewed-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarFangzhi Zuo <jerry.zuo@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1a63bda8

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+0 −3
Original line number Diff line number Diff line
@@ -12245,9 +12245,6 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector, 
	} else if (edid && sink->sink_signal == SIGNAL_TYPE_HDMI_TYPE_A) {

		i = parse_hdmi_amd_vsdb(amdgpu_dm_connector, edid, &vsdb_info);

		if (i >= 0 && vsdb_info.freesync_supported) {

			timing  = &edid->detailed_timings[i];

			data    = &timing->data.other_data;



			amdgpu_dm_connector->min_vfreq = vsdb_info.min_refresh_rate_hz;

			amdgpu_dm_connector->max_vfreq = vsdb_info.max_refresh_rate_hz;

			if (amdgpu_dm_connector->max_vfreq - amdgpu_dm_connector->min_vfreq > 10)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c

+8 −40
Original line number Diff line number Diff line
@@ -1529,7 +1529,6 @@ static ssize_t dp_dsc_clock_en_read(struct file *f, char __user *buf, 
				    size_t size, loff_t *pos)

{

	char *rd_buf = NULL;

	char *rd_buf_ptr = NULL;

	struct amdgpu_dm_connector *aconnector = file_inode(f)->i_private;

	struct display_stream_compressor *dsc;

	struct dcn_dsc_state dsc_state = {0};
@@ -1543,8 +1542,6 @@ static ssize_t dp_dsc_clock_en_read(struct file *f, char __user *buf, 
	if (!rd_buf)

		return -ENOMEM;



	rd_buf_ptr = rd_buf;



	for (i = 0; i < MAX_PIPES; i++) {

		pipe_ctx = &aconnector->dc_link->dc->current_state->res_ctx.pipe_ctx[i];

		if (pipe_ctx->stream &&
@@ -1558,10 +1555,9 @@ static ssize_t dp_dsc_clock_en_read(struct file *f, char __user *buf, 
	if (dsc)

		dsc->funcs->dsc_read_state(dsc, &dsc_state);



	snprintf(rd_buf_ptr, str_len,

	snprintf(rd_buf, str_len,

		"%d\n",

		dsc_state.dsc_clock_en);

	rd_buf_ptr += str_len;



	while (size) {

		if (*pos >= rd_buf_size)
@@ -1719,7 +1715,6 @@ static ssize_t dp_dsc_slice_width_read(struct file *f, char __user *buf, 
				    size_t size, loff_t *pos)

{

	char *rd_buf = NULL;

	char *rd_buf_ptr = NULL;

	struct amdgpu_dm_connector *aconnector = file_inode(f)->i_private;

	struct display_stream_compressor *dsc;

	struct dcn_dsc_state dsc_state = {0};
@@ -1733,8 +1728,6 @@ static ssize_t dp_dsc_slice_width_read(struct file *f, char __user *buf, 
	if (!rd_buf)

		return -ENOMEM;



	rd_buf_ptr = rd_buf;



	for (i = 0; i < MAX_PIPES; i++) {

		pipe_ctx = &aconnector->dc_link->dc->current_state->res_ctx.pipe_ctx[i];

		if (pipe_ctx->stream &&
@@ -1748,10 +1741,9 @@ static ssize_t dp_dsc_slice_width_read(struct file *f, char __user *buf, 
	if (dsc)

		dsc->funcs->dsc_read_state(dsc, &dsc_state);



	snprintf(rd_buf_ptr, str_len,

	snprintf(rd_buf, str_len,

		"%d\n",

		dsc_state.dsc_slice_width);

	rd_buf_ptr += str_len;



	while (size) {

		if (*pos >= rd_buf_size)
@@ -1907,7 +1899,6 @@ static ssize_t dp_dsc_slice_height_read(struct file *f, char __user *buf, 
				    size_t size, loff_t *pos)

{

	char *rd_buf = NULL;

	char *rd_buf_ptr = NULL;

	struct amdgpu_dm_connector *aconnector = file_inode(f)->i_private;

	struct display_stream_compressor *dsc;

	struct dcn_dsc_state dsc_state = {0};
@@ -1921,8 +1912,6 @@ static ssize_t dp_dsc_slice_height_read(struct file *f, char __user *buf, 
	if (!rd_buf)

		return -ENOMEM;



	rd_buf_ptr = rd_buf;



	for (i = 0; i < MAX_PIPES; i++) {

		pipe_ctx = &aconnector->dc_link->dc->current_state->res_ctx.pipe_ctx[i];

		if (pipe_ctx->stream &&
@@ -1936,10 +1925,9 @@ static ssize_t dp_dsc_slice_height_read(struct file *f, char __user *buf, 
	if (dsc)

		dsc->funcs->dsc_read_state(dsc, &dsc_state);



	snprintf(rd_buf_ptr, str_len,

	snprintf(rd_buf, str_len,

		"%d\n",

		dsc_state.dsc_slice_height);

	rd_buf_ptr += str_len;



	while (size) {

		if (*pos >= rd_buf_size)
@@ -2091,7 +2079,6 @@ static ssize_t dp_dsc_bits_per_pixel_read(struct file *f, char __user *buf, 
				    size_t size, loff_t *pos)

{

	char *rd_buf = NULL;

	char *rd_buf_ptr = NULL;

	struct amdgpu_dm_connector *aconnector = file_inode(f)->i_private;

	struct display_stream_compressor *dsc;

	struct dcn_dsc_state dsc_state = {0};
@@ -2105,8 +2092,6 @@ static ssize_t dp_dsc_bits_per_pixel_read(struct file *f, char __user *buf, 
	if (!rd_buf)

		return -ENOMEM;



	rd_buf_ptr = rd_buf;



	for (i = 0; i < MAX_PIPES; i++) {

		pipe_ctx = &aconnector->dc_link->dc->current_state->res_ctx.pipe_ctx[i];

		if (pipe_ctx->stream &&
@@ -2120,10 +2105,9 @@ static ssize_t dp_dsc_bits_per_pixel_read(struct file *f, char __user *buf, 
	if (dsc)

		dsc->funcs->dsc_read_state(dsc, &dsc_state);



	snprintf(rd_buf_ptr, str_len,

	snprintf(rd_buf, str_len,

		"%d\n",

		dsc_state.dsc_bits_per_pixel);

	rd_buf_ptr += str_len;



	while (size) {

		if (*pos >= rd_buf_size)
@@ -2270,7 +2254,6 @@ static ssize_t dp_dsc_pic_width_read(struct file *f, char __user *buf, 
				    size_t size, loff_t *pos)

{

	char *rd_buf = NULL;

	char *rd_buf_ptr = NULL;

	struct amdgpu_dm_connector *aconnector = file_inode(f)->i_private;

	struct display_stream_compressor *dsc;

	struct dcn_dsc_state dsc_state = {0};
@@ -2284,8 +2267,6 @@ static ssize_t dp_dsc_pic_width_read(struct file *f, char __user *buf, 
	if (!rd_buf)

		return -ENOMEM;



	rd_buf_ptr = rd_buf;



	for (i = 0; i < MAX_PIPES; i++) {

		pipe_ctx = &aconnector->dc_link->dc->current_state->res_ctx.pipe_ctx[i];

		if (pipe_ctx->stream &&
@@ -2299,10 +2280,9 @@ static ssize_t dp_dsc_pic_width_read(struct file *f, char __user *buf, 
	if (dsc)

		dsc->funcs->dsc_read_state(dsc, &dsc_state);



	snprintf(rd_buf_ptr, str_len,

	snprintf(rd_buf, str_len,

		"%d\n",

		dsc_state.dsc_pic_width);

	rd_buf_ptr += str_len;



	while (size) {

		if (*pos >= rd_buf_size)
@@ -2328,7 +2308,6 @@ static ssize_t dp_dsc_pic_height_read(struct file *f, char __user *buf, 
				    size_t size, loff_t *pos)

{

	char *rd_buf = NULL;

	char *rd_buf_ptr = NULL;

	struct amdgpu_dm_connector *aconnector = file_inode(f)->i_private;

	struct display_stream_compressor *dsc;

	struct dcn_dsc_state dsc_state = {0};
@@ -2342,8 +2321,6 @@ static ssize_t dp_dsc_pic_height_read(struct file *f, char __user *buf, 
	if (!rd_buf)

		return -ENOMEM;



	rd_buf_ptr = rd_buf;



	for (i = 0; i < MAX_PIPES; i++) {

		pipe_ctx = &aconnector->dc_link->dc->current_state->res_ctx.pipe_ctx[i];

		if (pipe_ctx->stream &&
@@ -2357,10 +2334,9 @@ static ssize_t dp_dsc_pic_height_read(struct file *f, char __user *buf, 
	if (dsc)

		dsc->funcs->dsc_read_state(dsc, &dsc_state);



	snprintf(rd_buf_ptr, str_len,

	snprintf(rd_buf, str_len,

		"%d\n",

		dsc_state.dsc_pic_height);

	rd_buf_ptr += str_len;



	while (size) {

		if (*pos >= rd_buf_size)
@@ -2401,7 +2377,6 @@ static ssize_t dp_dsc_chunk_size_read(struct file *f, char __user *buf, 
				    size_t size, loff_t *pos)

{

	char *rd_buf = NULL;

	char *rd_buf_ptr = NULL;

	struct amdgpu_dm_connector *aconnector = file_inode(f)->i_private;

	struct display_stream_compressor *dsc;

	struct dcn_dsc_state dsc_state = {0};
@@ -2415,8 +2390,6 @@ static ssize_t dp_dsc_chunk_size_read(struct file *f, char __user *buf, 
	if (!rd_buf)

		return -ENOMEM;



	rd_buf_ptr = rd_buf;



	for (i = 0; i < MAX_PIPES; i++) {

		pipe_ctx = &aconnector->dc_link->dc->current_state->res_ctx.pipe_ctx[i];

		if (pipe_ctx->stream &&
@@ -2430,10 +2403,9 @@ static ssize_t dp_dsc_chunk_size_read(struct file *f, char __user *buf, 
	if (dsc)

		dsc->funcs->dsc_read_state(dsc, &dsc_state);



	snprintf(rd_buf_ptr, str_len,

	snprintf(rd_buf, str_len,

		"%d\n",

		dsc_state.dsc_chunk_size);

	rd_buf_ptr += str_len;



	while (size) {

		if (*pos >= rd_buf_size)
@@ -2474,7 +2446,6 @@ static ssize_t dp_dsc_slice_bpg_offset_read(struct file *f, char __user *buf, 
				    size_t size, loff_t *pos)

{

	char *rd_buf = NULL;

	char *rd_buf_ptr = NULL;

	struct amdgpu_dm_connector *aconnector = file_inode(f)->i_private;

	struct display_stream_compressor *dsc;

	struct dcn_dsc_state dsc_state = {0};
@@ -2488,8 +2459,6 @@ static ssize_t dp_dsc_slice_bpg_offset_read(struct file *f, char __user *buf, 
	if (!rd_buf)

		return -ENOMEM;



	rd_buf_ptr = rd_buf;



	for (i = 0; i < MAX_PIPES; i++) {

		pipe_ctx = &aconnector->dc_link->dc->current_state->res_ctx.pipe_ctx[i];

		if (pipe_ctx->stream &&
@@ -2503,10 +2472,9 @@ static ssize_t dp_dsc_slice_bpg_offset_read(struct file *f, char __user *buf, 
	if (dsc)

		dsc->funcs->dsc_read_state(dsc, &dsc_state);



	snprintf(rd_buf_ptr, str_len,

	snprintf(rd_buf, str_len,

		"%d\n",

		dsc_state.dsc_slice_bpg_offset);

	rd_buf_ptr += str_len;



	while (size) {

		if (*pos >= rd_buf_size)