Commit ea185406 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpuidle: teo: Combine candidate state index checks against 0 



There are two candidate state index checks against 0 in teo_select()
that need not be separate, so combine them and update comments around
them.

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarChristian Loehle <christian.loehle@arm.com>
Tested-by: default avatarAboorva Devarajan <aboorvad@linux.ibm.com>
Tested-by: default avatarChristian Loehle <christian.loehle@arm.com>
Link: https://patch.msgid.link/13676346.uLZWGnKmhe@rjwysocki.net
parent 92ce5c07

drivers/cpuidle/governors/teo.c

+9 −14
Original line number Diff line number Diff line
@@ -436,22 +436,17 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, 
	if (idx > constraint_idx)

		idx = constraint_idx;



	if (!idx && prev_intercept_idx) {

	if (!idx) {

		if (prev_intercept_idx) {

			/*

		 * We have to query the sleep length here otherwise we don't

		 * know after wakeup if our guess was correct.

			 * Query the sleep length to be able to count the wakeup

			 * as a hit if it is caused by a timer.

			 */

			duration_ns = tick_nohz_get_sleep_length(&delta_tick);

			cpu_data->sleep_length_ns = duration_ns;

		goto out_tick;

		}



	/*

	 * Skip the timers check if state 0 is the current candidate one,

	 * because an immediate non-timer wakeup is expected in that case.

	 */

	if (!idx)

		goto out_tick;

	}



	/*

	 * If state 0 is a polling one, check if the target residency of