Commit ea327035 authored by Carolina Jubran's avatar Carolina Jubran Committed by Jakub Kicinski
Browse files

net/mlx5: Remove redundant bw_share minimal value assignment 



Remove unnecessary logic that sets bw_share to minimal value, when
parent has bw_share configured but nodes don't have min_rate.

This check is redundant because the parent bandwidth acts as the upper
bound regardless, and the firmware always enforces the topmost
bandwidth constraint.

Signed-off-by: default avatarCarolina Jubran <cjubran@nvidia.com>
Reviewed-by: default avatarCosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/1763415729-1238421-4-git-send-email-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 391dad2e

drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c

+0 −7
Original line number Diff line number Diff line
@@ -341,13 +341,6 @@ static u32 esw_qos_calculate_min_rate_divider(struct mlx5_eswitch *esw, 
	if (max_guarantee)

		return max_t(u32, max_guarantee / fw_max_bw_share, 1);



	/* If nodes max min_rate divider is 0 but their parent has bw_share

	 * configured, then set bw_share for nodes to minimal value.

	 */



	if (parent && parent->bw_share)

		return 1;



	/* If the node nodes has min_rate configured, a divider of 0 sets all

	 * nodes' bw_share to 0, effectively disabling min guarantees.

	 */