Commit ea59b12a authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: compress: fix to check compress flag w/ .i_sem lock 



It needs to check compress flag w/ .i_sem lock, otherwise, compressed
inode may be disabled after the check condition, it's not needed to
set compress option on non-compress inode.

Fixes: e1e8debe ("f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl")
Signed-off-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 7d009e04

fs/f2fs/file.c

+8 −4
Original line number Diff line number Diff line
@@ -4028,8 +4028,7 @@ static int f2fs_ioc_set_compress_option(struct file *filp, unsigned long arg) 
				sizeof(option)))

		return -EFAULT;



	if (!f2fs_compressed_file(inode) ||

			option.log_cluster_size < MIN_COMPRESS_LOG_SIZE ||

	if (option.log_cluster_size < MIN_COMPRESS_LOG_SIZE ||

		option.log_cluster_size > MAX_COMPRESS_LOG_SIZE ||

		option.algorithm >= COMPRESS_MAX)

		return -EINVAL;
@@ -4038,6 +4037,11 @@ static int f2fs_ioc_set_compress_option(struct file *filp, unsigned long arg) 
	inode_lock(inode);



	f2fs_down_write(&F2FS_I(inode)->i_sem);

	if (!f2fs_compressed_file(inode)) {

		ret = -EINVAL;

		goto out;

	}



	if (f2fs_is_mmap_file(inode) || get_dirty_pages(inode)) {

		ret = -EBUSY;

		goto out;