Commit ea5e911e authored by Rodrigo Gobbi's avatar Rodrigo Gobbi Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove unused debug statements 



Remove both commented printk() and commented DEBUG_ERR()
statements around the driver.

Signed-off-by: default avatarRodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Link: https://lore.kernel.org/r/20241015014738.41685-3-rodrigo.gobbi.7@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent be11b268

drivers/staging/rtl8723bs/hal/hal_com.c

+0 −1
Original line number Diff line number Diff line
@@ -867,7 +867,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter) 
	int save_cnt = false;



	/* switch counter to RX fifo */

	/* printk("8723b or 8192e , MAC_667 set 0xf0\n"); */

	rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|0xf0);

	save_cnt = true;

	/* todo: other chips */

drivers/staging/rtl8723bs/hal/odm.c

+0 −4
Original line number Diff line number Diff line
@@ -431,7 +431,6 @@ static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm_t *pDM_Odm) 
				continue;



			if (true == ODM_RAStateCheck(pDM_Odm, pstat->rssi_stat.UndecoratedSmoothedPWDB, false, &pstat->rssi_level)) {

				/* printk("RSSI:%d, RSSI_LEVEL:%d\n", pstat->rssi_stat.UndecoratedSmoothedPWDB, pstat->rssi_level); */

				rtw_hal_update_ra_mask(pstat, pstat->rssi_level);

			}
@@ -510,7 +509,6 @@ bool ODM_RAStateCheck( 
		RATRState = DM_RATR_STA_MIDDLE;

	else

		RATRState = DM_RATR_STA_LOW;

	/* printk("==>%s, RATRState:0x%02x , RSSI:%d\n", __func__, RATRState, RSSI); */



	if (*pRATRState != RATRState || bForceUpdate) {

		*pRATRState = RATRState;
@@ -591,8 +589,6 @@ static void odm_RSSIMonitorCheckCE(struct dm_odm_t *pDM_Odm) 
			}

		}



		/* printk("%s ==> sta_cnt(%d)\n", __func__, sta_cnt); */



		for (i = 0; i < sta_cnt; i++) {

			if (PWDB_rssi[i] != (0)) {

				if (pHalData->fw_ractrl == true)/*  Report every sta's RSSI to FW */

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

+0 −2
Original line number Diff line number Diff line
@@ -53,8 +53,6 @@ static int _BlockWrite(struct adapter *padapter, void *buffer, u32 buffSize) 
	u8 *bufferPtr = buffer;

	u32 i = 0, offset = 0;



/* 	printk("====>%s %d\n", __func__, __LINE__); */



	/* 3 Phase #1 */

	blockCount_p1 = buffSize / blockSize_p1;

	remainSize_p1 = buffSize % blockSize_p1;

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c

+1 −11
Original line number Diff line number Diff line
@@ -581,7 +581,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa 


				memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));



				/* DEBUG_ERR("set key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len); */

				/* set mic key */

				memcpy(txkey, &(param->u.crypt.key[16]), 8);

				memcpy(rxkey, &(param->u.crypt.key[24]), 8);
@@ -626,7 +625,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa 
				} else if (strcmp(param->u.crypt.alg, "TKIP") == 0) {

					psta->dot118021XPrivacy = _TKIP_;



					/* DEBUG_ERR("set key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len); */

					/* set mic key */

					memcpy(psta->dot11tkiptxmickey.skey, &(param->u.crypt.key[16]), 8);

					memcpy(psta->dot11tkiprxmickey.skey, &(param->u.crypt.key[24]), 8);
@@ -657,7 +655,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa 


					memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));



					/* DEBUG_ERR("set key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len); */

					/* set mic key */

					memcpy(txkey, &(param->u.crypt.key[16]), 8);

					memcpy(rxkey, &(param->u.crypt.key[24]), 8);
@@ -785,7 +782,6 @@ static int rtw_cfg80211_set_encryption(struct net_device *dev, struct ieee_param 
					memcpy(psta->dot118021x_UncstKey.skey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));



					if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */

						/* DEBUG_ERR(("\nset key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len)); */

						memcpy(psta->dot11tkiptxmickey.skey, &(param->u.crypt.key[16]), 8);

						memcpy(psta->dot11tkiprxmickey.skey, &(param->u.crypt.key[24]), 8);
@@ -806,10 +802,6 @@ static int rtw_cfg80211_set_encryption(struct net_device *dev, struct ieee_param 
					} else if (strcmp(param->u.crypt.alg, "BIP") == 0) {

						/* save the IGTK key, length 16 bytes */

						memcpy(padapter->securitypriv.dot11wBIPKey[param->u.crypt.idx].skey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));

						/*

						for (no = 0;no<16;no++)

							printk(" %02x ", padapter->securitypriv.dot11wBIPKey[param->u.crypt.idx].skey[no]);

						*/

						padapter->securitypriv.dot11wBIPKeyid = param->u.crypt.idx;

						padapter->securitypriv.binstallBIPkey = true;

					}
@@ -817,9 +809,7 @@ static int rtw_cfg80211_set_encryption(struct net_device *dev, struct ieee_param 
			}



			pbcmc_sta = rtw_get_bcmc_stainfo(padapter);

			if (!pbcmc_sta) {

				/* DEBUG_ERR(("Set OID_802_11_ADD_KEY: bcmc stainfo is null\n")); */

			} else {

			if (pbcmc_sta) {

				/* Jeff: don't disable ieee8021x_blocked while clearing key */

				if (strcmp(param->u.crypt.alg, "none") != 0)

					pbcmc_sta->ieee8021x_blocked = false;

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

+2 −15
Original line number Diff line number Diff line
@@ -138,9 +138,7 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, 


		if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_MP_STATE) == true) { /* sta mode */

			psta = rtw_get_stainfo(pstapriv, get_bssid(pmlmepriv));

			if (!psta) {

				/* DEBUG_ERR(("Set wpa_set_encryption: Obtain Sta_info fail\n")); */

			} else {

			if (psta) {

				/* Jeff: don't disable ieee8021x_blocked while clearing key */

				if (strcmp(param->u.crypt.alg, "none") != 0)

					psta->ieee8021x_blocked = false;
@@ -154,7 +152,6 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, 
					memcpy(psta->dot118021x_UncstKey.skey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));



					if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */

						/* DEBUG_ERR(("\nset key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len)); */

						memcpy(psta->dot11tkiptxmickey.skey, &param->u.crypt.key[16], 8);

						memcpy(psta->dot11tkiprxmickey.skey, &param->u.crypt.key[24], 8);
@@ -177,13 +174,8 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, 


						rtw_set_key(padapter, &padapter->securitypriv, param->u.crypt.idx, 1, true);

					} else if (strcmp(param->u.crypt.alg, "BIP") == 0) {

						/* printk("BIP key_len =%d , index =%d @@@@@@@@@@@@@@@@@@\n", param->u.crypt.key_len, param->u.crypt.idx); */

						/* save the IGTK key, length 16 bytes */

						memcpy(padapter->securitypriv.dot11wBIPKey[param->u.crypt.idx].skey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));

						/*printk("IGTK key below:\n");

						for (no = 0;no<16;no++)

							printk(" %02x ", padapter->securitypriv.dot11wBIPKey[param->u.crypt.idx].skey[no]);

						printk("\n");*/

						padapter->securitypriv.dot11wBIPKeyid = param->u.crypt.idx;

						padapter->securitypriv.binstallBIPkey = true;

					}
@@ -191,9 +183,7 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, 
			}



			pbcmc_sta = rtw_get_bcmc_stainfo(padapter);

			if (!pbcmc_sta) {

				/* DEBUG_ERR(("Set OID_802_11_ADD_KEY: bcmc stainfo is null\n")); */

			} else {

			if (pbcmc_sta) {

				/* Jeff: don't disable ieee8021x_blocked while clearing key */

				if (strcmp(param->u.crypt.alg, "none") != 0)

					pbcmc_sta->ieee8021x_blocked = false;
@@ -629,7 +619,6 @@ static int rtw_set_encryption(struct net_device *dev, struct ieee_param *param, 


				memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));



				/* DEBUG_ERR("set key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len); */

				/* set mic key */

				memcpy(txkey, &param->u.crypt.key[16], 8);

				memcpy(psecuritypriv->dot118021XGrprxmickey[param->u.crypt.idx].skey, &param->u.crypt.key[24], 8);
@@ -674,7 +663,6 @@ static int rtw_set_encryption(struct net_device *dev, struct ieee_param *param, 
				} else if (strcmp(param->u.crypt.alg, "TKIP") == 0) {

					psta->dot118021XPrivacy = _TKIP_;



					/* DEBUG_ERR("set key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len); */

					/* set mic key */

					memcpy(psta->dot11tkiptxmickey.skey, &param->u.crypt.key[16], 8);

					memcpy(psta->dot11tkiprxmickey.skey, &param->u.crypt.key[24], 8);
@@ -703,7 +691,6 @@ static int rtw_set_encryption(struct net_device *dev, struct ieee_param *param, 


					memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));



					/* DEBUG_ERR("set key length :param->u.crypt.key_len =%d\n", param->u.crypt.key_len); */

					/* set mic key */

					memcpy(txkey, &param->u.crypt.key[16], 8);

					memcpy(rxkey, &param->u.crypt.key[24], 8);