Commit ea9376cf authored by Shruti Parab's avatar Shruti Parab Committed by David S. Miller
Browse files

bnxt_en: Fix coredump logic to free allocated buffer 



When handling HWRM_DBG_COREDUMP_LIST FW command in
bnxt_hwrm_dbg_dma_data(), the allocated buffer info->dest_buf is
not freed in the error path.  In the normal path, info->dest_buf
is assigned to coredump->data and it will eventually be freed after
the coredump is collected.

Free info->dest_buf immediately inside bnxt_hwrm_dbg_dma_data() in
the error path.

Fixes: c74751f4 ("bnxt_en: Return error if FW returns more data than dump length")
Reported-by: default avatarMichael Chan <michael.chan@broadcom.com>
Reviewed-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarShruti Parab <shruti.parab@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c2d20a38

drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c

+5 −0
Original line number Diff line number Diff line
@@ -116,6 +116,11 @@ static int bnxt_hwrm_dbg_dma_data(struct bnxt *bp, void *msg, 
				memcpy(info->dest_buf + off, dma_buf, len);

			} else {

				rc = -ENOBUFS;

				if (cmn_req->req_type ==

				    cpu_to_le16(HWRM_DBG_COREDUMP_LIST)) {

					kfree(info->dest_buf);

					info->dest_buf = NULL;

				}

				break;

			}

		}