Commit eac04428 authored by Lukasz Czapnik's avatar Lukasz Czapnik Committed by Tony Nguyen
Browse files

i40e: add mask to apply valid bits for itr_idx 



The ITR index (itr_idx) is only 2 bits wide. When constructing the
register value for QINT_RQCTL, all fields are ORed together. Without
masking, higher bits from itr_idx may overwrite adjacent fields in the
register.

Apply I40E_QINT_RQCTL_ITR_INDX_MASK to ensure only the intended bits are
set.

Fixes: 5c3c48ac ("i40e: implement virtual device interface")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarLukasz Czapnik <lukasz.czapnik@intel.com>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Tested-by: default avatarRafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent cb79fa71

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

+1 −1
Original line number Diff line number Diff line
@@ -448,7 +448,7 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id, 
		    (qtype << I40E_QINT_RQCTL_NEXTQ_TYPE_SHIFT) |

		    (pf_queue_id << I40E_QINT_RQCTL_NEXTQ_INDX_SHIFT) |

		    BIT(I40E_QINT_RQCTL_CAUSE_ENA_SHIFT) |

		    (itr_idx << I40E_QINT_RQCTL_ITR_INDX_SHIFT);

		    FIELD_PREP(I40E_QINT_RQCTL_ITR_INDX_MASK, itr_idx);

		wr32(hw, reg_idx, reg);

	}