Commit eaca6e5d authored by Stanislav Fomichev's avatar Stanislav Fomichev Committed by Jakub Kicinski
Browse files

eth: bnxt: request unconditional ops lock 



netdev_lock_ops conditionally grabs instance lock when queue_mgmt_ops
is defined. However queue_mgmt_ops support is signaled via FW
so we can sometimes boot without queue_mgmt_ops being set.
This will result in bnxt running without instance lock which
the driver now heavily depends on. Set request_ops_lock to true
unconditionally to always request netdev instance lock.

Fixes: 004b5008 ("eth: bnxt: remove most dependencies on RTNL")
Signed-off-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250309215851.2003708-2-sdf@fomichev.me


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 110eff17

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −0
Original line number Diff line number Diff line
@@ -16613,6 +16613,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) 
		bp->rss_cap |= BNXT_RSS_CAP_MULTI_RSS_CTX;

	if (BNXT_SUPPORTS_QUEUE_API(bp))

		dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops;

	dev->request_ops_lock = true;



	rc = register_netdev(dev);

	if (rc)