Commit eae8a56a authored by Liao Chang's avatar Liao Chang Committed by Peter Zijlstra
Browse files

uprobes: Remove redundant spinlock in uprobe_deny_signal() 



Since clearing a bit in thread_info is an atomic operation, the spinlock
is redundant and can be removed, reducing lock contention is good for
performance.

Signed-off-by: default avatarLiao Chang <liaochang1@huawei.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: default avatar"Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Acked-by: default avatarOleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20250124093826.2123675-2-liaochang1@huawei.com
parent fa5d0a82

kernel/events/uprobes.c

+0 −2
Original line number Diff line number Diff line
@@ -2302,9 +2302,7 @@ bool uprobe_deny_signal(void) 
	WARN_ON_ONCE(utask->state != UTASK_SSTEP);



	if (task_sigpending(t)) {

		spin_lock_irq(&t->sighand->siglock);

		clear_tsk_thread_flag(t, TIF_SIGPENDING);

		spin_unlock_irq(&t->sighand->siglock);



		if (__fatal_signal_pending(t) || arch_uprobe_xol_was_trapped(t)) {

			utask->state = UTASK_SSTEP_TRAPPED;